Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bubble sort function and its test case #31

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

Shree7676
Copy link
Contributor

No description provided.

Copy link
Collaborator

@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice test follow-up with parametrization. I'll just merge it.

(unfortunately, I think there was another PR that also touched this, and we can't merge both :()

raise NotImplementedError

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some projects might not like such changes (even if they are better). But I think most/may either auto-format anyway, or will ignore smaller things like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it
Thanks

@seberg seberg merged commit 53e3b93 into Nikoleta-v3:main Aug 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants