Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

change enum contants api #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StevenWatremez
Copy link
Contributor

@StevenWatremez StevenWatremez commented Mar 15, 2018

This PR change Attributes/Relationships enums and fix #27

@StevenWatremez StevenWatremez changed the title drop support for realmrReadOnly user info key drop support for realmReadOnly user info key Mar 15, 2018
@StevenWatremez StevenWatremez force-pushed the feature/change-enum-constants-api branch from e26a2fb to 197123b Compare March 15, 2018 14:06
@StevenWatremez StevenWatremez changed the title drop support for realmReadOnly user info key change enum contants api Mar 15, 2018
Copy link
Collaborator

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@AliSoftware
Copy link
Collaborator

⚠️ This will need us to do a major version, as the generated code will be a breaking change for apps using it

@AliSoftware
Copy link
Collaborator

@StevenWatremez Could you rebase the changes on master since other PRs have been merged since? Thx

@StevenWatremez StevenWatremez force-pushed the feature/change-enum-constants-api branch from e6d4810 to b3b48a3 Compare March 16, 2018 16:47
@AliSoftware AliSoftware force-pushed the feature/change-enum-constants-api branch from b3b48a3 to 4a42851 Compare March 23, 2018 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change constants from "case" to "static let" in Attribute/Relationship enums
2 participants