NijiDigital · StevenWatremez · Mar 15, 2018 · Mar 15, 2018 · Mar 15, 2018 · Mar 15, 2018
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,9 @@
 * Improve error and warning messages when targetting an xcdatamodeld.  
   [Steven Watremez](https://github.com/StevenWatremez)
   [#53](https://github.com/NijiDigital/gyro/pull/53)
+* Stop supporting `realmReadOnly` user info key.  
+  [Steven Watremez](https://github.com/StevenWatremez)
+  [#57](https://github.com/NijiDigital/gyro/pull/57)
 
 ## 1.4.0
 

diff --git a/UserInfoKeys.md b/UserInfoKeys.md
@@ -9,7 +9,6 @@ Below are details about how to annotate your `.xcdatamodel` entities and attribu
 
 - [Primary key](#primary-key)
 - [Ignore attribute](#ignore-attribute)
-- [Read only](#read-only)
 - [Inverse Relationships](#inverse-relationships)
 - [Optionnals fields and wrapper types](#optionnals-fields-and-wrapper-types)
 - [Support Annotations](#support-annotations)
@@ -143,56 +142,6 @@ final class Shop: Object {
 </details>
 
 
----
-
-<a name="read-only"></a>
-# Read only (DEPRECATED)
-
-<details>
-<summary> Information about read only 'user info'</summary>
-On iOS/macOS, you can define attributes which are not persisted and whose value is computed dynamically.
-To do so, add the following 'user info' to **the attribute**
-
-| Key | Value |
-|-----|-------|
-| `realmReadOnly` | `the_code_source_to_generate` |
-
-
-__Example__: On the `readOnly`  attribute of the `Shop`  entity:
-
-![Read Only](documentation/read_only.png)
-</details>
-
-<details>
-<summary>📑 Sample of the generated code in Objective-C (iOS)</summary>
-
-```objc
-// DO NOT EDIT | Generated by gyro
-
-////////////////////////////////////////////////////////////////////////////////
-
-#pragma mark - Imports
-
-#import "RLMShop.h"
-
-////////////////////////////////////////////////////////////////////////////////
-
-#pragma mark - Implementation
-
-@implementation RLMShop
-
-#pragma mark - Superclass Overrides
-
-- (NSString *)readOnly
-{
-    return self.name;
-}
-
-@end
-```
-</details>
-
-
 ---
 
 <a name="inverse-relationships"></a>
@@ -570,6 +519,8 @@ extension Shop: Mappable {
 
 </details>
 
+---
+
 <a name="combine-jsonkeypath-and-enums"></a>
 ## Combine JSONKeyPath and enums
 

diff --git a/documentation/read_only.png b/documentation/read_only.png
diff --git a/lib/gyro/parser/xcdatamodel/attribute.rb b/lib/gyro/parser/xcdatamodel/attribute.rb
@@ -19,7 +19,7 @@ module XCDataModel
       #
       class Attribute
         attr_accessor :entity_name, :name, :type, :optional, :indexed, :default
-        attr_accessor :realm_ignored, :realm_read_only, :enum_type, :enum_values
+        attr_accessor :realm_ignored, :enum_type, :enum_values
         attr_accessor :json_key_path, :json_values, :transformer, :comment, :support_annotation, :json_ignored
 
         alias optional? optional
@@ -36,7 +36,6 @@ def initialize(attribute_xml, entity_name)
           @default = attribute_xml.attributes['defaultValueString'].to_s
           @type = attribute_xml.attributes['attributeType'].to_s.downcase.tr(' ', '_').to_sym
           @realm_ignored = !Gyro::Parser::XCDataModel.user_info(attribute_xml, 'realmIgnored').empty?
-          @realm_read_only = Gyro::Parser::XCDataModel.user_info(attribute_xml, 'realmReadOnly')
           @enum_type = Gyro::Parser::XCDataModel.user_info(attribute_xml, 'enumType')
           @enum_values = Gyro::Parser::XCDataModel.user_info(attribute_xml, 'enumValues').split(',')
           @json_key_path = Gyro::Parser::XCDataModel.user_info(attribute_xml, 'JSONKeyPath')
@@ -55,7 +54,7 @@ def to_h
             'optional' => optional,
             'indexed' => indexed,
             'default' => default,
-            'realm_ignored' => realm_ignored, 'realm_read_only' => realm_read_only,
+            'realm_ignored' => realm_ignored,
             'enum_type' => enum_type, 'enum_values' => enum_values,
             'json_key_path' => json_key_path, 'json_values' => json_values,
             'json_ignored' => json_ignored,
@@ -71,10 +70,6 @@ def enum?
           !@enum_type.empty?
         end
 
-        def read_only?
-          !@realm_read_only.empty?
-        end
-
         def default?
           [email protected]?
         end

diff --git a/lib/templates/android-java/inc/_attributes_enum.liquid b/lib/templates/android-java/inc/_attributes_enum.liquid
@@ -2,7 +2,7 @@
 
     public static final class Attributes {
     {%- for attribute in entity.attributes -%}
-      {%- if attribute.realm_ignored == false or attribute.read_only == false -%}
+      {%- if attribute.realm_ignored == false -%}
         {%- if attribute.comment.size > 0 %}
         // {{ attribute.comment }}
         {%- endif %}

diff --git a/lib/templates/android-java/inc/_attributes_getter_setter.liquid b/lib/templates/android-java/inc/_attributes_getter_setter.liquid
@@ -1,6 +1,4 @@
 {%- for attribute in entity.attributes %}
-
-    {%- if attribute.realm_read_only.size == 0 %}
         {%- comment %} ******* CONVERT TYPE CAPTURE ******* {% endcomment -%}
 
         {%- capture visibility %}
@@ -12,7 +10,7 @@
         {%- endcapture %}
 
         {%- capture convert_type %}
-          {%- if attribute.realm_read_only.size == 0 and attribute.enum_type.size > 0 -%}
+          {%- if attribute.enum_type.size > 0 -%}
             String
           {%- else -%}
             {%- if params.use_wrappers.size > 0 and attribute.optional == true -%}
@@ -54,5 +52,4 @@
     {{ visibility }} void set{{ name | titleize }}({%- if annotation.size > 0 %}{{ annotation | replace: "|"," " }} {% endif %}final {{ convert_type }} {{ name }}) {
         this.{{ name }} = {{ name }};
     }
-    {%- endif %}
 {%- endfor %}
diff --git a/lib/templates/android-java/inc/_attributes_properties.liquid b/lib/templates/android-java/inc/_attributes_properties.liquid
@@ -1,8 +1,7 @@
 {% for attribute in entity.attributes -%}
-  {%- if attribute.realm_read_only.size == 0 -%}
       {%- comment %} ******* CONVERT TYPE CAPTURE ******* {% endcomment -%}
       {%- capture convert_type -%}
-        {%- if attribute.realm_read_only.size == 0 and attribute.enum_type.size > 0 -%}
+        {%- if attribute.enum_type.size > 0 -%}
           String
         {%- else -%}
           {%- if params.use_wrappers == "true" and attribute.optional == true -%}
@@ -49,5 +48,4 @@
     @android.support.annotation.{{ attribute.support_annotation }}
       {%- endif %}
     private {{ convert_type }} {{ name }}{{ default_value }};
-  {%- endif -%}
 {%- endfor -%}
diff --git a/lib/templates/android-java/inc/_enum_getter_setter.liquid b/lib/templates/android-java/inc/_enum_getter_setter.liquid
@@ -1,6 +1,6 @@
 {%- for attribute in entity.attributes %}
 
-    {%- if attribute.realm_read_only.size == 0 and attribute.enum_type.size > 0 %}
+    {%- if attribute.enum_type.size > 0 %}
         {% if params.support_annotations.size > 0 %}
     @android.support.annotation.Nullable
         {%- capture annotation -%}@android.support.annotation.NonNull {% endcapture -%}

diff --git a/lib/templates/android-java/inc/_primitives.liquid b/lib/templates/android-java/inc/_primitives.liquid
@@ -1,5 +1,5 @@
 {%- capture convert_type %}
-  {%- if attribute.realm_read_only.size == 0 and attribute.enum_type.size > 0 -%}
+  {%- if attribute.enum_type.size > 0 -%}
     String
   {%- else -%}
     {%- if params.use_wrappers.size > 0 and attribute.optional == true -%}

diff --git a/lib/templates/android-java/inc/_relationships_getter_setter.liquid b/lib/templates/android-java/inc/_relationships_getter_setter.liquid
@@ -1,7 +1,7 @@
 {%- for relationship in entity.relationships %}
     {%- if relationship.inverse == false %}
         {%- capture relationship_type %}
-          {%- if relationship.realm_read_only.size == 0 and relationship.enum_type.size > 0 -%}
+          {%- if relationship.enum_type.size > 0 -%}
             String
           {%- else %}
             {%- if relationship.destination.size == 0 %}

diff --git a/lib/templates/android-java/inc/_relationships_properties.liquid b/lib/templates/android-java/inc/_relationships_properties.liquid
@@ -1,6 +1,6 @@
 {%- for relationship in entity.relationships -%}
   {%- capture relationship_type -%}
-    {%- if relationship.realm_read_only.size == 0 and relationship.enum_type.size > 0 -%}
+    {%- if relationship.enum_type.size > 0 -%}
       String
     {%- else -%}
       {%- if relationship.destination.size == 0 -%}

diff --git a/lib/templates/android-kotlin/inc/_attributes_enum.liquid b/lib/templates/android-kotlin/inc/_attributes_enum.liquid
@@ -2,7 +2,7 @@
 
     object Attributes {
     {%- for attribute in entity.attributes -%}
-      {%- if attribute.realm_ignored == false or attribute.read_only == false -%}
+      {%- if attribute.realm_ignored == false -%}
         {%- if attribute.comment.size > 0 %}
         // {{ attribute.comment }}
         {%- endif %}

diff --git a/lib/templates/android-kotlin/inc/_attributes_properties.liquid b/lib/templates/android-kotlin/inc/_attributes_properties.liquid
@@ -1,16 +1,15 @@
 {% for attribute in entity.attributes -%}
-  {%- if attribute.realm_read_only.size == 0 -%}
       {%- comment %} ******* CONVERT TYPE CAPTURE ******* {% endcomment -%}
       {%- capture convert_type -%}
-        {%- if attribute.realm_read_only.size == 0 and attribute.enum_type.size > 0 -%}
+        {%- if attribute.enum_type.size > 0 -%}
           String
         {%- else -%}
           {%- include 'inc/type_converter' -%} 
         {%- endif -%}
       {%- endcapture -%}
 
       {%- capture is_primitive %}
-        {%- if attribute.realm_read_only.size == 0 and attribute.enum_type.size > 0 -%}
+        {%- if attribute.enum_type.size > 0 -%}
           false
         {%- else -%}
           {%- include 'inc/type_primitives' -%} 
@@ -56,5 +55,4 @@
     @SerializedName("{{ attribute.json_key_path }}") 
       {%- endif %}
     var {{ name }}: {{ convert_type }}{{ nullable_type }}{{ default_value }}
-  {%- endif -%}
 {%- endfor -%}
diff --git a/lib/templates/android-kotlin/inc/_enum_getter_setter.liquid b/lib/templates/android-kotlin/inc/_enum_getter_setter.liquid
@@ -1,6 +1,6 @@
 {%- for attribute in entity.attributes %}
 
-    {%- if attribute.realm_read_only.size == 0 and attribute.enum_type.size > 0 %}
+    {%- if attribute.enum_type.size > 0 %}
         {%- assign name = attribute.name %}
 
     fun get{{ name | titleize }}Enum(): {{ attribute.enum_type }}? = {{ attribute.enum_type }}.get({{ name }})

diff --git a/lib/templates/android-kotlin/inc/_primitives.liquid b/lib/templates/android-kotlin/inc/_primitives.liquid
@@ -1,5 +1,5 @@
 {%- capture convert_type %}
-  {%- if attribute.realm_read_only.size == 0 and attribute.enum_type.size > 0 -%}
+  {%- if attribute.enum_type.size > 0 -%}
     String
   {%- else -%}
     {%- if params.use_wrappers.size > 0 and attribute.optional == true -%}

diff --git a/lib/templates/android-kotlin/inc/_relationships_properties.liquid b/lib/templates/android-kotlin/inc/_relationships_properties.liquid
@@ -1,6 +1,6 @@
 {%- for relationship in entity.relationships -%}
   {%- capture relationship_type -%}
-    {%- if relationship.realm_read_only.size == 0 and relationship.enum_type.size > 0 -%}
+    {%- if relationship.enum_type.size > 0 -%}
       String
     {%- else -%}
       {%- if relationship.destination.size == 0 -%}

diff --git a/lib/templates/swift3-variant/inc/_attributes_enum.liquid b/lib/templates/swift3-variant/inc/_attributes_enum.liquid
@@ -2,7 +2,7 @@
 {% if entity.attributes.size > 0 %}
   enum Attributes: String {
     {%- for attribute in entity.attributes -%}
-        {%- if attribute.realm_ignored or attribute.realm_read_only.size == 0 -%}
+        {%- if attribute.realm_ignored == false -%}
             {%- if attribute.comment.size > 0 %}
     /// {{ attribute.comment }}
             {%- endif %}

diff --git a/lib/templates/swift3-variant/inc/_attributes_properties.liquid b/lib/templates/swift3-variant/inc/_attributes_properties.liquid
@@ -9,18 +9,16 @@
     {%- include 'inc/type_converter' -%}
   {%- endcapture -%}
 
-  {%- if attribute.realm_read_only.size == 0 -%}
-    {%- if attribute.enum_values.size > 0 -%}
-      {%- comment -%} ******* GENERATE ENUM ATTRIBUTE PROPERTY ******* {% endcomment -%}
-      {%- include 'inc/enum_attribute_property' -%}
-        {%- else -%}
-          {%- if attribute.optional == true -%}
-            {% comment -%} ******* GENERATE OPTIONAL ATTRIBUTE PROPERTY ******* {% endcomment -%}
-            {%- include 'inc/optional_attribute_property' -%}
-          {%- else -%}
-            {%- comment -%} ******* GENERATE DEFAULT ATTRIBUTE PROPERTY ******* {% endcomment %}
+  {%- if attribute.enum_values.size > 0 -%}
+    {%- comment -%} ******* GENERATE ENUM ATTRIBUTE PROPERTY ******* {% endcomment -%}
+    {%- include 'inc/enum_attribute_property' -%}
+  {%- else -%}
+    {%- if attribute.optional == true -%}
+      {% comment -%} ******* GENERATE OPTIONAL ATTRIBUTE PROPERTY ******* {% endcomment -%}
+      {%- include 'inc/optional_attribute_property' -%}
+    {%- else -%}
+      {%- comment -%} ******* GENERATE DEFAULT ATTRIBUTE PROPERTY ******* {% endcomment %}
   dynamic var {{ attribute.name }}: {{ convert_type }} = {{ default_value }}
-          {%- endif -%}
     {%- endif -%}
   {%- endif -%}
 {%- endfor -%}

diff --git a/lib/templates/swift3/inc/_attributes_enum.liquid b/lib/templates/swift3/inc/_attributes_enum.liquid
@@ -2,7 +2,7 @@
 {% if entity.attributes.size > 0 %}
   enum Attributes: String {
     {%- for attribute in entity.attributes -%}
-        {%- if attribute.realm_ignored or attribute.realm_read_only.size == 0 -%}
+        {%- if attribute.realm_ignored == false -%}
             {%- if attribute.comment.size > 0 %}
     /// {{ attribute.comment }}
             {%- endif %}

diff --git a/lib/templates/swift3/inc/_attributes_properties.liquid b/lib/templates/swift3/inc/_attributes_properties.liquid
@@ -9,17 +9,17 @@
     {%- include 'inc/type_converter' -%}
   {%- endcapture -%}
 
-  {%- if attribute.realm_read_only.size == 0 -%}
-    {%- if attribute.enum_values.size > 0 -%}
-      {%- comment -%} ******* GENERATE ENUM ATTRIBUTE PROPERTY ******* {% endcomment -%}
-      {%- include 'inc/enum_attribute_property' -%}
-    {%- else -%}{%- if attribute.optional == true -%}
+  {%- if attribute.enum_values.size > 0 -%}
+    {%- comment -%} ******* GENERATE ENUM ATTRIBUTE PROPERTY ******* {% endcomment -%}
+    {%- include 'inc/enum_attribute_property' -%}
+  {%- else -%}
+    {%- if attribute.optional == true -%}
       {% comment -%} ******* GENERATE OPTIONAL ATTRIBUTE PROPERTY ******* {% endcomment -%}
       {%- include 'inc/optional_attribute_property' -%}
     {%- else -%}
     {%- comment -%} ******* GENERATE DEFAULT ATTRIBUTE PROPERTY ******* {% endcomment %}
   @objc dynamic var {{ attribute.name }}: {{ convert_type }} = {{ default_value }} {%- if attribute.name == entity.identity_attribute %} /* Primary Key */{% endif -%}
-    {%- endif -%}{%- endif -%}
+    {%- endif -%}
   {%- endif -%}
 {%- endfor -%}
 

diff --git a/spec/fixtures/java/ignored/Shop.java b/spec/fixtures/java/ignored/Shop.java
@@ -11,7 +11,6 @@ public class Shop extends RealmObject {
 
     public static final class Attributes {
         public static final String NAME = "name";
-        public static final String READ_ONLY = "readOnly";
 
         private Attributes() {
             // Hide constructor

diff --git a/spec/fixtures/kotlin/ignored/Shop.kt b/spec/fixtures/kotlin/ignored/Shop.kt
@@ -11,7 +11,6 @@ open class Shop : RealmObject() {
 
     object Attributes {
         const val NAME: String = "name"
-        const val READ_ONLY: String = "readOnly"
     }
 
     object Relationships {

diff --git a/spec/fixtures/swift/ignored/Shop.swift b/spec/fixtures/swift/ignored/Shop.swift
@@ -6,8 +6,6 @@ import Foundation
 final class Shop: Object {
 
   enum Attributes: String {
-    case ignored = "ignored"
-    case ignored2 = "ignored2"
     case name = "name"
   }
 

diff --git a/spec/fixtures/xcdatamodel/ignored.xcdatamodel/contents b/spec/fixtures/xcdatamodel/ignored.xcdatamodel/contents
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
-<model type="com.apple.IDECoreDataModeler.DataModel" documentVersion="1.0" lastSavedToolsVersion="12141" systemVersion="16E195" minimumToolsVersion="Xcode 4.3" sourceLanguage="Objective-C" userDefinedModelVersionIdentifier="">
+<model type="com.apple.IDECoreDataModeler.DataModel" documentVersion="1.0" lastSavedToolsVersion="13772" systemVersion="16G1212" minimumToolsVersion="Xcode 4.3" sourceLanguage="Objective-C" userDefinedModelVersionIdentifier="">
     <entity name="Owner" syncable="YES">
         <attribute name="name" optional="YES" attributeType="String" syncable="YES"/>
         <relationship name="shop" optional="YES" maxCount="1" deletionRule="Nullify" destinationEntity="Shop" inverseName="owner" inverseEntity="Shop" syncable="YES">
@@ -23,17 +23,12 @@
             </userInfo>
         </attribute>
         <attribute name="name" attributeType="String" syncable="YES"/>
-        <attribute name="readOnly" attributeType="String" syncable="YES">
-            <userInfo>
-                <entry key="realmReadOnly" value="return self.name;"/>
-            </userInfo>
-        </attribute>
         <relationship name="owner" optional="YES" maxCount="1" deletionRule="Nullify" destinationEntity="Owner" inverseName="shop" inverseEntity="Owner" syncable="YES"/>
         <relationship name="products" toMany="YES" deletionRule="Nullify" destinationEntity="Product" inverseName="shop" inverseEntity="Product" syncable="YES"/>
     </entity>
     <elements>
         <element name="Owner" positionX="135" positionY="225" width="128" height="75"/>
         <element name="Product" positionX="216" positionY="279" width="128" height="60"/>
-        <element name="Shop" positionX="54" positionY="144" width="128" height="135"/>
+        <element name="Shop" positionX="54" positionY="144" width="128" height="120"/>
     </elements>
 </model>