Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hover): correct dynamic hover functionality to work like in apg #318

Merged
merged 10 commits into from
Jun 25, 2024
Merged

fix(hover): correct dynamic hover functionality to work like in apg #318

merged 10 commits into from
Jun 25, 2024

Conversation

NickDJM
Copy link
Owner

@NickDJM NickDJM commented Jun 24, 2024

Related Issues

See #303

@NickDJM
Copy link
Owner Author

NickDJM commented Jun 24, 2024 •
edited
Loading

Remaining tasks:

  • Submenus also need to stay open when leaving the menu entirely.
  • When you hover over a non-submenu item in the root menu (closing all submenus) all sub menus still need to open on hover. This will need a new value probably for "can hover" or something instead of checking if there's already an open menu.
  • Tests for the above cases

@NickDJM NickDJM marked this pull request as draft June 24, 2024 20:13
@NickDJM NickDJM self-assigned this Jun 24, 2024
@NickDJM NickDJM mentioned this pull request Jun 24, 2024
Closed
@NickDJM NickDJM marked this pull request as ready for review June 25, 2024 15:59
@NickDJM NickDJM merged commit 818cd3b into 4.x Jun 25, 2024
5 checks passed
@NickDJM NickDJM deleted the 303-fix-dynamic-hover branch June 25, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@NickDJM NickDJM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NickDJM