fix(hover): handle cancelling hover events when re-entering menu items #314
Conversation
…rs within leaveDelay ms
This resolves some strange interactions with transitioning classes
…r control This fixes a bug causing menus to close and reopen depending on the situation
|
I've been thinking about this over the weekend and I think this being a breaking change is actually tackling the problem the wrong way... The reason we needed to move the timeout was because of how treeviews work with hover... And "fixing" it with moving the timeout makes treeviews even more of a nightmare with hovering. I think the real solution (which includes the cancelling of timeouts are such) will be to also just overhaul how treeviews work with hover. I think the treeview items should stay open at all times until the menu is left, and then things can close. Doing this would remove the need to move the timeout tracker and prevent this from being a breaking change. |
|
Ok I've swapped everything. I think all that's left is a few test cases to write and updating the documentation. The treeview changes will come after. |
|
Ok docs have been updated and tests have been written. This should be good to go. |
Making this MR so I can run automated tests without waiting to merge the other one.
Related Issues
#300 #299