Merge pull request #350 from NickDJM/330-eslint-upgrade

330 eslint upgrade

package.json

@@ -138,9 +138,8 @@
     "@vitest/ui": "^1.2.2",
     "commitizen": "^4.3.0",
     "cz-conventional-changelog": "^3.3.0",
-    "eslint": "^8.43.0",
+    "eslint": "^9.11.1",
     "eslint-config-prettier": "^9.0.0",
-    "eslint-config-standard": "^17.1.0",
     "eslint-plugin-jsdoc": "^50.0.0",
     "globals": "^15.0.0",
     "husky": "^9.1.1",

src/_baseMenu.js

@@ -29,7 +29,7 @@ class BaseMenu {
    *
    * @type {typeof BaseMenu}
    */
-  _MenuType = BaseMenu; // eslint-disable-line no-use-before-define
+  _MenuType = BaseMenu;
 
   /**
    * The class to use when generating menu items.

src/_baseMenuItem.js

@@ -1,4 +1,3 @@
-// eslint-disable-next-line no-unused-vars
 /* global BaseMenu, BaseMenuToggle */
 
 /**

src/_baseMenuToggle.js

@@ -1,4 +1,3 @@
-// eslint-disable-next-line no-unused-vars
 /* global BaseMenu */
 
 import { addClass, removeClass } from "./domHelpers.js";

src/disclosureMenu.js

@@ -19,7 +19,7 @@ class DisclosureMenu extends BaseMenu {
    *
    * @type {typeof DisclosureMenu}
    */
-  _MenuType = DisclosureMenu; // eslint-disable-line no-use-before-define
+  _MenuType = DisclosureMenu;
 
   /**
    * The class to use when generating menu items.

src/disclosureMenuItem.js

@@ -1,4 +1,3 @@
-// eslint-disable-next-line no-unused-vars
 /* global DisclosureMenu, DisclosureMenuToggle */
 
 import BaseMenuItem from "./_baseMenuItem.js";

src/disclosureMenuToggle.js

@@ -1,4 +1,3 @@
-// eslint-disable-next-line no-unused-vars
 /* global DisclosureMenu */
 
 import BaseMenuToggle from "./_baseMenuToggle.js";

src/eventHandlers.js

@@ -24,7 +24,7 @@ export function keyPress(event) {
     };
 
     return Object.keys(keys).find((key) => keys[key] === true) || "";
-  } catch (error) {
+  } catch {
     // Return an empty string if something goes wrong.
     return "";
   }

src/menubar.js

@@ -30,7 +30,7 @@ class Menubar extends BaseMenu {
    *
    * @type {typeof Menubar}
    */
-  _MenuType = Menubar; // eslint-disable-line no-use-before-define
+  _MenuType = Menubar;
 
   /**
    * The class to use when generating menu items.

src/menubarItem.js

@@ -1,4 +1,3 @@
-// eslint-disable-next-line no-unused-vars
 /* global Menubar, MenubarToggle */
 
 import BaseMenuItem from "./_baseMenuItem.js";

src/menubarToggle.js

@@ -1,4 +1,3 @@
-// eslint-disable-next-line no-unused-vars
 /* global Menubar */
 
 import BaseMenuToggle from "./_baseMenuToggle.js";

src/topLinkDisclosureMenu.js

@@ -31,7 +31,7 @@ class TopLinkDisclosureMenu extends BaseMenu {
    *
    * @type {typeof TopLinkDisclosureMenu}
    */
-  _MenuType = TopLinkDisclosureMenu; // eslint-disable-line no-use-before-define
+  _MenuType = TopLinkDisclosureMenu;
 
   /**
    * The class to use when generating menu items.

src/topLinkDisclosureMenuItem.js

@@ -1,4 +1,3 @@
-// eslint-disable-next-line no-unused-vars
 /* global TopLinkDisclosureMenu, TopLinkDisclosureMenuToggle */
 
 import BaseMenuItem from "./_baseMenuItem.js";

src/topLinkDisclosureMenuToggle.js

@@ -1,4 +1,3 @@
-// eslint-disable-next-line no-unused-vars
 /* global TopLinkDisclosureMenu */
 
 import BaseMenuToggle from "./_baseMenuToggle.js";

src/treeview.js

@@ -30,7 +30,7 @@ class Treeview extends BaseMenu {
    *
    * @type {typeof Treeview}
    */
-  _MenuType = Treeview; // eslint-disable-line no-use-before-define
+  _MenuType = Treeview;
 
   /**
    * The class to use when generating menu items.

src/treeviewItem.js

@@ -1,4 +1,3 @@
-// eslint-disable-next-line no-unused-vars
 /* global Treeview, TreeviewToggle */
 
 import BaseMenuItem from "./_baseMenuItem.js";

src/treeviewToggle.js

@@ -1,4 +1,3 @@
-// eslint-disable-next-line no-unused-vars
 /* global Treeview */
 
 import BaseMenuToggle from "./_baseMenuToggle.js";

src/validate.js

@@ -117,7 +117,7 @@ export function isQuerySelector(values) {
         }
 
         document.querySelector(values[key]);
-      } catch (error) {
+      } catch {
         throw new TypeError(
           `${key} must be a valid query selector. "${values[key]}" given.`
         );

tests/menus/DisclosureMenu/initialize.test.js

@@ -5,8 +5,6 @@
  * that the Disclosure class can be initialized.
  */
 
-/* eslint-disable no-new */
-
 import {
   describe,
   it,

tests/menus/Menubar/initialize.test.js

@@ -5,8 +5,6 @@
  * that the Menubar class can be initialized.
  */
 
-/* eslint-disable no-new */
-
 import {
   describe,
   it,

tests/menus/TopLinkDisclosureMenu/initialize.test.js

@@ -5,8 +5,6 @@
  * that the TopLinkDisclosureMenu class can be initialized.
  */
 
-/* eslint-disable no-new */
-
 import {
   describe,
   it,

tests/menus/Treeview/initialize.test.js

@@ -5,8 +5,6 @@
  * that the Treeview class can be initialized.
  */
 
-/* eslint-disable no-new */
-
 import {
   describe,
   it,

tests/menus/helpers.js

@@ -2,7 +2,6 @@
  * Helper functions for testing menus.
  */
 
-// eslint-disable-next-line no-unused-vars
 /* global BaseMenu */
 
 /**