Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update PP calculators for standard, catch and mania #257

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: update PP calculators for standard, catch and mania #257

wants to merge 4 commits into from

Conversation

minisbett
Copy link
Contributor

Self-check

  • The changes are tested with pre-commit
  • The changes pass unit testing with pytest
  • The changes pass mypy

NiceAesth
NiceAesth requested changes Dec 5, 2024
View reviewed changes
Copy link
Owner

@NiceAesth NiceAesth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

writing this down but theres so many typing things that i will just look at this in the weekend

aiosu/utils/performance.py Outdated Show resolved Hide resolved
aiosu/utils/performance.py
full_combo_threshold = self.difficulty_attributes.max_combo - 0.1 * score.beatmap.count_sliders # type: ignore

if score.max_combo < full_combo_threshold:
effective_miss_count = full_combo_threshold / max(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
effective_miss_count = full_combo_threshold / max(
effective_miss_count = full_combo_threshold // max(

not sure if this is right though?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

effective misscount is a decimal number

aiosu/utils/performance.py
full_combo_threshold = self.difficulty_attributes.max_combo - (score.beatmap.count_sliders - score.statistics.count_slider_tail_hit) # type: ignore

if score.max_combo < full_combo_threshold:
effective_miss_count = full_combo_threshold / max(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
effective_miss_count = full_combo_threshold / max(
effective_miss_count = full_combo_threshold // max(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiceAesth NiceAesth NiceAesth requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minisbett @NiceAesth