feat: update handling for score urls

NiceAesth · Feb 9, 2024 · 904dc5a · 904dc5a
1 parent b198d74
commit 904dc5a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/aiosu/models/lazer.py b/aiosu/models/lazer.py
@@ -177,11 +177,12 @@ def score_url(self) -> Optional[str]:
         """
         if not self.id:
             return None
-        return (
-            f"https://osu.ppy.sh/scores/{self.id}"
-            if self.type == "solo_score"
-            else f"https://osu.ppy.sh/scores/{self.mode.name_api}/{self.best_id}"
-        )
+        if self.type == "solo_score":
+            return f"https://osu.ppy.sh/scores/{self.id}"
+
+        if not self.best_id:  # Legacy URL format
+            return None
+        return f"https://osu.ppy.sh/scores/{self.mode.name_api}/{self.best_id}"
 
     @property
     def replay_url(self) -> Optional[str]:

diff --git a/aiosu/models/score.py b/aiosu/models/score.py
@@ -173,11 +173,12 @@ def score_url(self) -> Optional[str]:
         """
         if not self.id:
             return None
-        return (
-            f"https://osu.ppy.sh/scores/{self.id}"
-            if self.type == "solo_score"
-            else f"https://osu.ppy.sh/scores/{self.mode.name_api}/{self.best_id}"
-        )
+        if self.type == "solo_score":
+            return f"https://osu.ppy.sh/scores/{self.id}"
+
+        if not self.best_id or not self.passed:  # Legacy URL format
+            return None
+        return f"https://osu.ppy.sh/scores/{self.mode.name_api}/{self.best_id}"
 
     @property
     def replay_url(self) -> Optional[str]: