Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update create2 deploy and governance scripts #1284

Draft
wants to merge 16 commits into
base: release-candidate
Choose a base branch
from
Draft

feat: update create2 deploy and governance scripts #1284

wants to merge 16 commits into from

Conversation

rackstar
Copy link
Contributor

@rackstar rackstar commented Nov 18, 2024 •
edited
Loading

Description

Closes #1258

  • add tenderly network support for create2/deploy script
    • uses the deployer address to deploy to tenderly testnet - mimicking exactly what would happen in main-net
  • re-wrote governance inputs encode/decode to generalise its logic
  • simulate governance proposal script
  • execute governance proposal script - (useful when setting up vnets to closely mimic what will happen on-chain)

Testing

  • tested the scripts on the 2.10.0 release

Checklist

  • Performed a self-review of my own code
  • Made corresponding changes to the documentation

@rackstar rackstar self-assigned this Nov 18, 2024
@rackstar rackstar force-pushed the feat/script-improvements-and-docs branch from 693f5d1 to 669baed Compare November 18, 2024 14:36
rackstar and others added 16 commits January 14, 2025 13:04
@rackstar @shark0der
docs: update ProposalCategory.editCategory _incentives params docs
83c62ef
@rackstar @shark0der
feat: add tenderly support to create2 deploy script
3b0bd6f
@rackstar @shark0der
feat: add generic decodeParamData function
5416d9d
@rackstar @shark0der
feat: add generic getEncodedAction function
ff1ccda
@rackstar @shark0der
test: add fork test for individual Pool asset balances
67b560c
@rackstar @shark0der
chore: add constants file to avoid circular dependency
fcc19bf
@rackstar @shark0der
refactor: rename script to simulate-createProposalWithSolution-txdata
aded8f4
@rackstar @shark0der
feat: add execute-createProposalWithSolution-txdata
721b119
@rackstar @shark0der
feat: dynamically generate -a flag info for get-encoded-action-data
665e582
@rackstar @shark0der
refactor: rename file helper function to verifyDecodedCreateProposalT…
d0a8020 
…xInputs
@rackstar @shark0der
refactor: code clean up
6c71048
@rackstar @shark0der
docs: update function annotations
b4b7b8e
@rackstar @shark0der
refactor: use contract deployer address when deploying locally
f88b98c
@rackstar @shark0der
docs: add PROPOSAL_CATEGORY constant annotations
1f44def
@rackstar @shark0der
docs: add/extend function annotation for create2 and governance scripts
cea77ac
@shark0der
revert: remove viewer deployment script
2fa1aed
@shark0der shark0der force-pushed the feat/script-improvements-and-docs branch from ce2ae28 to 2fa1aed Compare January 14, 2025 11:04
@rackstar rackstar marked this pull request as draft January 14, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shark0der shark0der Awaiting requested review from shark0der

@MilGard91 MilGard91 Awaiting requested review from MilGard91

At least 1 approving review is required to merge this pull request.

Assignees

@rackstar rackstar

Labels
feature
Projects
Engineering Tracker 💻
Status: TODO
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Governance proposal script - add support for "Add Asset To Pool" (42)
2 participants
@rackstar @shark0der