Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node events memory leak fixes #16169

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Node events memory leak fixes #16169

wants to merge 8 commits into from

Conversation

IDCs
Copy link
Contributor

@IDCs IDCs commented Aug 5, 2024 •
edited
Loading

The rest of the leaks are within the collections extension; still trying to figure out how to deal with that without rocking the boat too much.

The functionality for the main app is still solid though.

  • Ensures that the symlink activator is no longer "stuck" behind the elevation notification.
  • Better error handling throughout the application, React errors will no longer block the entire page view when something fails to render, it will block the specific component that failed to render (which can indeed be a whole page in some cases)
  • Dynamic divs are now wrapped in an ErrorBoundary and will provide a way for users to report any rendering issues that occur.
  • General improvements to the DOM's consistency (removed anti-patterns) - this might screw up the stylesheets a bit (specifically for ECD)
  • Ensured that we add and remove listeners correctly in the QuickLauncher and MainWindow components.

Please ignore until 1.13.x is worked on

@IDCs
Fixed QuickLauncher component not removing listeners correctly
e56e847 
This branch will include multiple bugfixes across the core app meant
to ensure we release any hanging event listeners and ensure we find
the memory leak
@IDCs
Ensure dynamic content is wrapped in an ErrorBoundary comp
31774ae
@IDCs
fixed ErrorBoundary component not rendering when error occurrs
9c781aa
@IDCs
fixed ECD creating non-unique links
6694336
@IDCs
fixed MainWindow not releasing event listeners correctly
16dd540
@IDCs
minor stuff, error handling + cleanup
a914e88
@IDCs
Revert "Ensure dynamic content is wrapped in an ErrorBoundary comp"
652b709 
Added the ErrorBoundary component to the dynamic div component itself
rather than tools_starter component

reverts 31774ae.
@IDCs
fixed inability to switch profiles when using symlink activator
d596c65 
The pre-existence of a userGate instance (which blocks deployment
events until a notification is interacted with) was blocking
game/profile changes when such a notification existed, the entirety of
the UX surrounding this piece of functionality is redundant as the
Windows elevation dialog would basically ask the same thing.

Elevation notification has been removed - Vortex will now raise the
WinAPI elevation dialog by default.
@IDCs IDCs requested a review from insomnious August 5, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insomnious insomnious Awaiting requested review from insomnious

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IDCs