Rework attributes to be instance based #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty massive overhaul of the attribute system to handle #37. More code was deleted here than added. And the net effect is that we're back to 400k datoms/sec insert on my machine.
What this PR does:
AttrId -> Attribute, AttrId -> ValueSerializer, etc.
into inline arrays.1 to 2^16
we can pre-allocate slots for all the attributes.X
database connections open at once is very rare, so we can pre-allocate those caches as well.X
is currently set to 8.IWriteDatom
class. This means that when writing data we never allocate a datom, just write the data straight to a buffer and then the transaction system streams it to disk.Attribute<T>
, and uses enums were useful.ulong
to aushort
. The values will never be higher than 2^16 anyway, but we had them as ulongs as technically they are EntityIds.File.Path, File.Size
and read the data viaFile.Model