Merge pull request #88 from Nexus-Mods/refcount-observables

Fix bug with RefCount and ObservableDatoms

src/NexusMods.MnemonicDB.Abstractions/Query/ObservableDatoms.cs

@@ -49,7 +49,7 @@ public static IObservable<IChangeSet<Datom>> ObserveDatoms(this IConnection conn
         {
             lock (set)
             {
-                if (rev.BasisTxId <= lastTxId)
+                if (rev.BasisTxId <= lastTxId && idx != 0)
                     return ChangeSet<Datom>.Empty;
 
                 lastTxId = rev.BasisTxId;

tests/NexusMods.MnemonicDB.Tests/DbTests.RefCountWorksWithObservables.verified.txt

@@ -0,0 +1,5 @@
+[
+  Test Mod,
+  Test Mod 2,
+  Test Mod 3
+]

tests/NexusMods.MnemonicDB.Tests/DbTests.cs

@@ -911,4 +911,50 @@ public async Task CollectionAttributesAreSupportedOnModels()
 
         modRO.Tags.Should().BeEquivalentTo(["A", "B", "C"]);
     }
+
+    /// <summary>
+    /// Tests a bug experienced in the app, when RefCount is used with ObserveDatoms, if the last subscription
+    /// is disposed, and then another subscriber attaches, an exception would be thrown. This test ensures that
+    /// this behavior works correctly.
+    /// </summary>
+    [Fact]
+    public async Task RefCountWorksWithObservables()
+    {
+        var tx = Connection.BeginTransaction();
+        var mod = new Mod.New(tx)
+        {
+            Name = "Test Mod",
+            Source = new Uri("http://test.com"),
+            LoadoutId = EntityId.From(0)
+        };
+        var result = await tx.Commit();
+
+        var modRO = result.Remap(mod);
+
+        var refObs = Mod.Observe(Connection, modRO.Id)
+            .Replay(1)
+            .RefCount();
+
+        List<Mod.ReadOnly> mods = [];
+
+        var firstDisp = refObs.Subscribe(mods.Add);
+
+        {
+            var tx2 = Connection.BeginTransaction();
+            tx2.Add(modRO.Id, Mod.Name, "Test Mod 2");
+            await tx2.Commit();
+        }
+
+        firstDisp.Dispose();
+
+        var secondDisp = refObs.Subscribe(mods.Add);
+
+        {
+            var tx2 = Connection.BeginTransaction();
+            tx2.Add(modRO.Id, Mod.Name, "Test Mod 3");
+            await tx2.Commit();
+        }
+
+        await Verify(mods.Distinct().Select(m => m.Name));
+    }
 }