Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous Improvements ahead of RePacking #22

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

Sewer56
Copy link
Member

@Sewer56 Sewer56 commented Jun 27, 2024

This PR contains a few miscellaneous improvements:

  • Nx can now pack files greater than 2GiB in size from disk.
    • Streams are still limited to 2GiB. will throw if the limit is breached.
    • This is a breaking change in binary. But not a breaking change in source.
  • A tiny refactor of the packing/unpacking steps.
    • Moved some of the packing/unpacking steps to separate files.
    • Added explanations on why each step is necessary and what it achieves.
    • This is to make the code reusable for repacking, and easier to understand.
  • Updated Documentation
    • Documentation now includes the previously missing Compression class, since it went from internal to public.
    • Documentation had some minor fixes, e.g. a typo in one code snippet.
    • Added extra notes.

@Sewer56 Sewer56 added the meta-improvement An issue that improves an existing feature label Jun 27, 2024
@Sewer56 Sewer56 self-assigned this Jun 27, 2024
@Sewer56 Sewer56 merged commit a4660d2 into main Jun 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-improvement An issue that improves an existing feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant