Net 9 and Update Deps #2251
Open
Net 9 and Update Deps #2251
+128
−221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al12rs
reviewed
Nov 18, 2024
| @@ -30,7 +30,7 @@ jobs: | |||
|
|
|||
| build-and-test: | |||
| if: github.event_name == 'push' || github.event.pull_request.draft == false | |||
| uses: Nexus-Mods/NexusMods.App.Meta/.github/workflows/dotnet-build-and-test-with-osx.yaml@ae64a3be780a74e94b59ee463a413083013c8b0c | |||
| uses: Nexus-Mods/NexusMods.App.Meta/.github/workflows/dotnet-build-and-test-with-osx.yaml@main | |||
There was a problem hiding this comment.
Not using a pinned version of the workflows could cause issues.
Changes to the Meta repo that also require changes to the underlying repos would break CI during the mean time.
E.g. while the PR with the changes is being reviewed, Ci on all other PRs will break.
Just pointing it out, in case it others have opinions on this
Al12rs
requested changes
Nov 18, 2024
Al12rs
reviewed
Nov 18, 2024
src/Abstractions/NexusMods.Abstractions.MnemonicDB.Attributes/RelativePathAttribute.cs
Outdated
Show resolved
Hide resolved
|
This PR conflicts with |
|
This PR doesn't conflict with |
erri120
requested changes
Nov 18, 2024
|
This PR conflicts with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following: