Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DateTimeOffset and TimeProvider #2246

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use DateTimeOffset and TimeProvider #2246

wants to merge 1 commit into from

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Nov 13, 2024

No description provided.

@erri120 erri120 requested a review from a team November 13, 2024 12:56
@erri120 erri120 self-assigned this Nov 13, 2024
@Al12rs
Copy link
Contributor

Al12rs commented Nov 13, 2024

Regarding the test failures, the GeneralModManagementTests failing because they contain transaction Ids that can randomly change based on the order of things happening in the DB, not relevant to the actual outcome.

I changed those tests to exclude EntityIds and TransactionIds from the verify snapshots in my Load Order PR #2248

@Al12rs
Copy link
Contributor

Al12rs commented Nov 13, 2024

I don't know about the other failures.
I reviewed the code and it looks good otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erri120 erri120

Labels
None yet
Projects
MVP
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erri120 @Al12rs