Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor/#310] 마이페이지 중복된 setTabBar 모디파이어 제거 #311

Merged
merged 1 commit into from
Oct 15, 2024
Merged

[refactor/#310] 마이페이지 중복된 setTabBar 모디파이어 제거 #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Projects/Feature/MyPage/Interface/Sources/MyPage/MyPageView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,7 @@ public struct MyPageView: View {
}
.scrollIndicators(.hidden)
.background(to: ColorToken.container(.primary))
.padding(.bottom, 106)
.padding(.top, 1)
.setTabBar(selectedTab: .myPage) { selectedTab in
store.send(.selectedTabDidChanged(selectedTab))
}
.onLoad {
store.send(.onLoad)
}
Expand Down
3 changes: 3 additions & 0 deletions Projects/Feature/MyPage/Interface/Sources/MyPageRootView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import SwiftUI

import FeatureTabBarInterface

import SharedDesignSystem

import ComposableArchitecture

public struct MyPageRootView: View {
Expand All @@ -22,6 +24,7 @@ public struct MyPageRootView: View {
WithPerceptionTracking {
NavigationStack(path: $store.scope(state: \.path, action: \.path)) {
MyPageView(store: store.scope(state: \.myPage, action: \.myPage))
.padding(.bottom, BottleConstants.bottomTabBarHeight.value)
.setTabBar(selectedTab: .myPage) { selectedTab in
store.send(.selectedTabDidChanged(selectedTab: selectedTab))
}
Expand Down