Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main Menu: Add coverflow menu style #314

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Main Menu: Add coverflow menu style #314

merged 2 commits into from
Jan 16, 2025

Conversation

CodyTolene
Copy link
Contributor

@CodyTolene CodyTolene commented Dec 1, 2024 •
edited by Willy-JL
Loading

What's new

  • Add support for scaling menu icons (0-100%)
  • Add new menu style: "CoverFlow"

CoverFlow

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

Willy-JL
Willy-JL requested changes Dec 1, 2024
View reviewed changes
Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please run ./fbt format

applications/services/gui/canvas.c Show resolved Hide resolved
@Willy-JL
Copy link
Member

Willy-JL commented Dec 2, 2024

i'll look closer (both at this and other open prs) and merge in the coming days, a bit swamped with uni deadlines right now. still, looks very cool, nice work!

@CodyTolene
Copy link
Contributor Author

Awesome sounds great @Willy-JL have a good night & happy holidays!

Willy-JL
Willy-JL approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theres a few small tweaks i would make, just technicalities, but it doesnt let me push to your fork's branch, please enable "allow edits by maintainers" next time, makes it easier :D

regardless, overall looks good, thanks!

@Willy-JL Willy-JL changed the title Add coverflow menu style. Main Menu: Add coverflow menu style Jan 16, 2025
@Willy-JL Willy-JL merged commit 530f3d4 into Next-Flip:dev Jan 16, 2025
@Willy-JL Willy-JL added the feature New feature or request label Jan 16, 2025
Willy-JL added a commit that referenced this pull request Jan 17, 2025
@Willy-JL
Small cleanup of #314 --nobuild
574933a
@CodyTolene
Copy link
Contributor Author

@Willy-JL Thanks man! Happy to contribute hopefully I can get some time for more in the future it sure was fun

@956MB 956MB mentioned this pull request Jan 17, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willy-JL Willy-JL Willy-JL approved these changes

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich is a code owner

Assignees

@CodyTolene CodyTolene

Labels
feature New feature or request
Projects
Momentum Progress Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodyTolene @Willy-JL