Fix: Editmode unable to save issue #53
Conversation
Don't hook :hideFrame when going into EditMode.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
hideBlizzardFrames()
Update ShadowedUnitFrames.lua
Replace deprecated function UnitDebuff to C_UnitAuras.GetDebuffDataByIndex
Replace deprecated function UnitDebuff to C_UnitAuras.GetDebuffDataByIndex
|
I'm not able to observe any issues with EditMode snapping or saving in current WoW with current SUF. Can you explain how to reproduce the issue? |
The issue occurs when I check any 'Hide Blizz frame' and enter to Edit mode. Detail of my settings: Details of the issue: *This issue has been quite long time for me and some of my friends like since DF Season 3 |
|
Confirm the same for me partially hidden the bliz frames use some parts then it breaks for me without this change. |
|
Please watch this https://www.youtube.com/watch?v=UpHkO9CobMU I had forgotten to mention the keystone of the error earlier. That was 'Snap to Elements' option in the Edit mode. You can find that in this video. |
Use unpack function for packed return data (because of replacing depreated function; UnitDebuff )
Use unpack function for packed return data
Set previous parents of frames before enter Editmode.
There was a problem hiding this comment.
This(set old_parent for every frames in ShadowedUnitFrames.lua) is essential fix.
I missed it when I upload code from my local repo to my github repo.
I set the parent before enter Blizz's Editmode.
It is necessary for every frame has their parents to save Edit mode when you enable 'Snap to elements' while SUF hides some blizz frames.
(And sorry for my poor skills to use git. I am so far from programming stuffs.)
Don't hook :hideFrame when going into EditMode.
(I am the same person who posted this- https://www.wowace.com/projects/shadowed-unit-frames/issues/2102)