Add vehicles back for Wrath #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge. SUF is unusable for wrath in its current state. |
|
With Stanzilla/WoWUIBugs#274 fixed, these changes are fully working on the 3.4.1 PTR and are compatible with Era @Nevcairiel. |
truchonh
added a commit
to truchonh/ShadowedUnitFrames
that referenced
this pull request
Jun 30, 2023
Code taken from Nevcairiel#25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started by reverting 42feaa1, then added several version checks to try to keep things compatible with TBC/Era.
I'm not sure if adding the Attributes to ShadowedUnitFrames.xml will break in Era or just no-op. If they break, it might need to be split into two xml files loaded by two separate tocs.
I also seem to be missing something with how the
toggleForVehicleattribute works; it seems like all of the functions inmodules/units.luaare running, and health amount+color are properly swapping. But targeting by clicking and mouseover aren't working, and/dump SUFUnitplayer:GetAttribute("unit")still returns "player" while in a vehicle.This isn't really a finished PR but hopefully it's a good starting point, as having vehicles working properly is pretty essential in Wrath.