Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make PatchClampSeries gain optional to match the schema #1975

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

stephprince
Copy link
Contributor

@stephprince stephprince commented Oct 24, 2024

Motivation

Fix #1971. PatchClampSeries.gain is an optional dataset in the schema but required by pynwb. This PR makes it optional in pynwb as well.

How to test the behavior?

Follow the icephys tutorial but remove gain as an argument from the VoltageClampSeries.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (e938202) to head (1c566db).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1975   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files          27       27           
  Lines        2695     2695           
  Branches      703      703           
=======================================
  Hits         2476     2476           
  Misses        145      145           
  Partials       74       74           
Flag Coverage Δ
integration 72.69% <100.00%> (ø)
unit 83.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephprince stephprince marked this pull request as ready for review October 31, 2024 18:33
@stephprince stephprince requested a review from rly October 31, 2024 18:33
Comment on lines +157 to +163
def test_gain_optional(self):
electrode_name = GetElectrode()

pCS = PatchClampSeries('test_pCS', list(), 'unit',
electrode_name, timestamps=list())
self.assertIsNone(pCS.gain)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an analogous roundtrip test to make sure read is OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PatchClampSeries gain is optional in the schema but required in pynwb
2 participants