Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test validate script and function directly and add test to CI #1326

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

rly
Copy link
Contributor

@rly rly commented Dec 8, 2020

Motivation

tests/validation/test_validate.py was not being called by any test scripts or CI. This PR adds test_validate.py to the test.py (under unit tests) and fixes it to work with the latest version of the PyNWB validator.

Also update the validator script so that if a namespace is given and found in the cached namespace, the validator uses it properly. Previously, it was not possible to validate an NWB file against a namespace that is not the most restrictive among the cached namespaces.

How to test the behavior?

python test.py

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR description clearly describes problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using #XXX notation where XXX is the issue number?

@rly rly requested a review from oruebel December 8, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant