Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add page for OpenNeuroDataShowcase #235

Merged
merged 16 commits into from
Jul 20, 2023
Merged

Add page for OpenNeuroDataShowcase #235

merged 16 commits into from
Jul 20, 2023

Conversation

weiglszonja
Copy link
Contributor

No description provided.

@weiglszonja weiglszonja marked this pull request as draft June 30, 2023 10:14
@weiglszonja weiglszonja marked this pull request as ready for review July 3, 2023 13:56
@weiglszonja weiglszonja marked this pull request as draft July 11, 2023 16:09
@bendichter bendichter marked this pull request as ready for review July 19, 2023 16:33
rly
rly reviewed Jul 19, 2023
View reviewed changes
HCK16_2023_OpenNeuroDataShowcase/README.md Outdated

## Application

Sign up to receive instructions to join Open Neurodata Showcase 2023 [here](https://forms.gle/dh8eArbw836TpLyq8).
Copy link
Contributor

@rly rly Jul 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the application link to present in the event as well?

@weiglszonja
Copy link
Contributor Author

@rly let me know if there is anything else to modify, it would be nice if this goes live today or tomorrow.

oruebel
oruebel approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rly
Copy link
Contributor

rly commented Jul 20, 2023

Looks good to me too

@rly
Copy link
Contributor

rly commented Jul 20, 2023 •
edited
Loading

Apparently the Test GitHub Pages Builds / run (pull_request) GitHub Action doesn't work on forks due to permission issues. We can test this on the main branch.

@rly rly merged commit d6a6785 into NeurodataWithoutBorders:main Jul 20, 2023
1 check failed
@rly rly deleted the add_neurodata_showcase_page branch July 20, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rly rly rly left review comments

@bendichter bendichter bendichter left review comments

@oruebel oruebel oruebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weiglszonja @rly @bendichter @oruebel