Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prototype for easier mapping #44

Merged
merged 6 commits into from
Apr 28, 2024
Merged

prototype for easier mapping #44

merged 6 commits into from
Apr 28, 2024

Conversation

CodyCBakerPhD
Copy link
Collaborator

Working on a new approach for simplifying the parameterization cases

@CodyCBakerPhD CodyCBakerPhD self-assigned this Apr 20, 2024
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding note here that I really should indicate somehow this was on the DataJoint WiFi

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review April 28, 2024 18:24
@CodyCBakerPhD
Copy link
Collaborator Author

@oruebel This is good to go - the sooner we get it through the fewer conflicts we'll have to fix here

For newly added tests or tests on other PRs, they can either use the previous structure or upgrade to the new one

Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll need to take a stab at updating the PR's for Zarr and LINDI/

@oruebel
Copy link
Contributor

oruebel commented Apr 28, 2024

@sinha-r this PR changes how we define the parametrize of tests to follow the design we discussed previously. I.e., we now have a dictionary, where each entry is a particular case with a set of parameters instead of having separate lists for each parameter we are specifying.

parameter_cases = dict(
    IBLTestCase1=dict(
        s3_url=get_s3_url(dandiset_id="000717", dandi_path="sub-mock/sub-mock_ses-ecephys1.nwb"),
    ),
    ClassicRos3TestCase=dict(s3_url="https://dandiarchive.s3.amazonaws.com/ros3test.nwb"),
)

@oruebel oruebel merged commit 71d7106 into main Apr 28, 2024
2 checks passed
@oruebel oruebel deleted the easier_mapping branch April 28, 2024 19:41
@oruebel
Copy link
Contributor

oruebel commented Apr 28, 2024

For newly added tests or tests on other PRs, they can either use the previous structure or upgrade to the new one

I updated #51 and #53 to use the new structure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants