Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to most recent hdmf-common-schema #566

Merged
merged 8 commits into from
Feb 6, 2024
Merged

Update to most recent hdmf-common-schema #566

merged 8 commits into from
Feb 6, 2024

Conversation

mavaylon1
Copy link
Contributor

Summary of changes

  • Update to most recent hdmf-common-schema
  • Update dates to 2024

Checklist

For all schema changes:

  • Add release notes for the PR to docs/format/source/format_release_notes.rst.

If this is the first schema change after a schema release (i.e., the version string in core/nwb.namespace.yaml does not
end in "-alpha"), then:

  • Update the version string in core/nwb.namespace.yaml and core/nwb.file.yaml to the next major/minor/patch
    version with the suffix "-alpha". For example, if the current version is 2.4.0 and this is a minor change, then the
    new version string should be "2.5.0-alpha".
  • Update the value of the version variable in docs/format/source/conf.py to the next version without the
    suffix "-alpha", e.g., "2.5.0".
  • Update the value of the release variable in docs/format/source/conf.py to the next version with the suffix
    "-alpha", e.g., "2.5.0-alpha".
  • Add a new section in the release notes docs/format/source/format_release_notes.rst for the new version
    with the date "Upcoming" in parentheses.

rly
rly previously approved these changes Feb 6, 2024
@rly rly marked this pull request as ready for review February 6, 2024 16:19
@rly
Copy link
Contributor

rly commented Feb 6, 2024

Looks like we had not updated hdmf-common-schema in 3 years, but that hasn't affected anything AFAIK because PyNWB uses HDMF which uses the latest hdmf-common-schema 1.8.0. I'm not sure if this will affect MatNWB @lawrence-mbf

@lawrence-mbf
Copy link

@rly The changes won't show until the next version of the schema since we don't use submodules but otherwise the changes look fine.

@rly rly merged commit f352a93 into dev Feb 6, 2024
5 checks passed
@rly rly deleted the common_schema branch February 6, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants