Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose logo for MatNWB #425

Merged
merged 1 commit into from
May 4, 2022
Merged

Propose logo for MatNWB #425

merged 1 commit into from
May 4, 2022

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented May 3, 2022

Motivation

We now have logos for most NWB-related tools (PyNWB, HDMF, NWBInsepctor etc.) and I figured it would be good to also have a logo for MatNWB. Since the Matlab logo is copyright protected I figured it would not be wise to try and do some form of combination of the NWB and Matlab logos. The logo I'm proposing here places the NWB logo in euclidean coordinate frame to represent both the Mat and NWB part of the name. The PowerPoint file has both a 2D and a 3D variant of the logo, but I think the 3D version looks more interesting. What do you think?

For now, I have place the logo into a new top-level folder. I was not sure where the right place for this is. Just let me know in case I should move the files to a different location.

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@bendichter
Copy link
Contributor

cute!

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #425 (c20d956) into master (7ea1abd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   86.00%   86.00%           
=======================================
  Files         125      125           
  Lines        5067     5067           
=======================================
  Hits         4358     4358           
  Misses        709      709           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea1abd...c20d956. Read the comment docs.

@lawrence-mbf
Copy link
Collaborator

My gut says that the logo should be under docs but we may want to do that after #417 is done.

@oruebel
Copy link
Contributor Author

oruebel commented May 4, 2022

the logo should be under docs but we may want to do that after #417 is done.

Sounds good. I added an item to #417 to note that we should consider moving the logos folder, just so we don't forget.

@oruebel oruebel merged commit 1836b93 into master May 4, 2022
@oruebel oruebel deleted the propose/logo branch May 4, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants