Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to retrieve keys in LindiH5pyFile class #87

Closed
wants to merge 2 commits into from
Closed

Conversation

magland
Copy link
Collaborator

@magland magland commented Jul 17, 2024

Fixes #86

@bendichter
Copy link

I confirm this works. Could you support client.items() as well?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.46%. Comparing base (731fcb5) to head (24c5371).
Report is 9 commits behind head on main.

Files Patch % Lines
lindi/LindiH5pyFile/LindiH5pyFile.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   79.43%   79.46%   +0.02%     
==========================================
  Files          30       30              
  Lines        2256     2269      +13     
==========================================
+ Hits         1792     1803      +11     
- Misses        464      466       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@magland
Copy link
Collaborator Author

magland commented Jul 18, 2024

I confirm this works. Could you support client.items() as well?

Yes this is now available. I have merged these into #84 and published as lindi 0.3.14.

(I am publishing that branch before it's actually merged into main because I need it for the newest neurosift/dendro stuff)

@magland magland closed this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repr error
3 participants