Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data read #85

Draft
wants to merge 69 commits into
base: main
Choose a base branch
from
Draft

Add data read #85

wants to merge 69 commits into from

Commits on Aug 31, 2024

  1. Define base classes for reading

    @oruebel
    oruebel committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    1e1f041 View commit details
    Browse the repository at this point in the history

  2. First draft of reading datasets and attributes

    @oruebel
    oruebel committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    e58f50f View commit details
    Browse the repository at this point in the history

  3. Split reading of attribute and dataset to separate functions

    @oruebel
    oruebel committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    250a66b View commit details
    Browse the repository at this point in the history

  4. Remove debug print

    @oruebel
    oruebel committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    e1bfa2e View commit details
    Browse the repository at this point in the history

  5. Add functions to construct ReadDatasetWrapper and ReadAttributeWrappe… 

    …r from BaseIO
    @oruebel
    oruebel committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    4aedefd View commit details
    Browse the repository at this point in the history

  6. Fix formatting

    @oruebel
    oruebel committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    4dae171 View commit details
    Browse the repository at this point in the history

  7. Add test for using the ReadDatasetWrapper

    @oruebel
    oruebel committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    140809e View commit details
    Browse the repository at this point in the history

  8. Start refactor containers for read

    @oruebel
    oruebel committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    4d7b1ea View commit details
    Browse the repository at this point in the history

  9. Fix format

    @oruebel
    oruebel committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    2db4bfe View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2024

  1. Read ElectricalSeries.data example working

    @oruebel
    oruebel committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    b2959d2 View commit details
    Browse the repository at this point in the history

  2. Revert change to tests used for debugging

    @oruebel
    oruebel committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    37d30d3 View commit details
    Browse the repository at this point in the history

  3. Fix codespell issue

    @oruebel
    oruebel committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    6cfe416 View commit details
    Browse the repository at this point in the history

  4. Move read example to an example file

    @oruebel
    oruebel committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    3d86aff View commit details
    Browse the repository at this point in the history

  5. Fix bug in Container::create

    @oruebel
    oruebel committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    3fc1d7a View commit details
    Browse the repository at this point in the history

  6. Add example for data read

    @oruebel
    oruebel committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    b09a4fa View commit details
    Browse the repository at this point in the history

  7. Fix spelling error

    @oruebel
    oruebel committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    970f4c8 View commit details
    Browse the repository at this point in the history

  8. Add user docs for data read

    @oruebel
    oruebel committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    26fbae9 View commit details
    Browse the repository at this point in the history

  9. Update read user docs

    @oruebel
    oruebel committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    4299f99 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Add toc

    @oruebel
    oruebel committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    9c9301c View commit details
    Browse the repository at this point in the history

  2. Add read software design figure and more details on the design

    @oruebel
    oruebel committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    447337a View commit details
    Browse the repository at this point in the history

  3. Some adjustment to the edges in the fig

    @oruebel
    oruebel committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    e3d4330 View commit details
    Browse the repository at this point in the history

  4. Some adjustment to the edges in the fig

    @oruebel
    oruebel committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    77f0861 View commit details
    Browse the repository at this point in the history

  5. Add intro for data read page

    @oruebel
    oruebel committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    5190731 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Make Container::create inline

    @oruebel
    oruebel committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f08e42f View commit details
    Browse the repository at this point in the history

  2. Make DataBlock::fromGeneric inline

    @oruebel
    oruebel committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    1a754b9 View commit details
    Browse the repository at this point in the history

  3. Implement function to allow us to get the storage object type for a g… 

    …iven path
    @oruebel
    oruebel committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ebfbdf1 View commit details
    Browse the repository at this point in the history

  4. Rename getObjectType to getStroageObjectType

    @oruebel
    oruebel committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    3022861 View commit details
    Browse the repository at this point in the history

  5. Fix reading of attributes and add TimeSeries.resolution read

    @oruebel
    oruebel committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6ba32a5 View commit details
    Browse the repository at this point in the history

  6. Add example for reading an attribute

    @oruebel
    oruebel committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    1fb5d95 View commit details
    Browse the repository at this point in the history

  7. Add ReadDataWrapperBase as common base class for ReadDatasetWrapper a… 

    …nd ReadAttributeWrapper
    @oruebel
    oruebel committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    676b978 View commit details
    Browse the repository at this point in the history

  8. Fix docstring

    @oruebel
    oruebel committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    14c8362 View commit details
    Browse the repository at this point in the history

  9. Minor fixed to docs

    @oruebel
    oruebel committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    d2b1c23 View commit details
    Browse the repository at this point in the history

  10. Mention ReadDataWrapperBase in the read dox page

    @oruebel
    oruebel committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    78825f2 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into add_read

    @oruebel
    oruebel committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    85db320 View commit details
    Browse the repository at this point in the history

  12. Fix unit tests after merge

    @oruebel
    oruebel committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    5c2faae View commit details
    Browse the repository at this point in the history

  13. Remove NWBFile.identifierText property

    @oruebel
    oruebel committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c481260 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Allow setting of value type template parameter for ReadDataWrapperBas… 

    …e and subtypes
    @oruebel
    oruebel committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b418149 View commit details
    Browse the repository at this point in the history

  2. Save the std::type_index as part of the DataBlock to support runtime … 

    …checking
    @oruebel
    oruebel committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    1f3ad24 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Fix #88 move io classes to their own module

    @oruebel
    oruebel committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    99b5d4e View commit details
    Browse the repository at this point in the history

  2. Refactor to add IO namespace to match folder structure

    @oruebel
    oruebel committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    04117e9 View commit details
    Browse the repository at this point in the history

  3. Move HDF5RecordingData to its own hpp/cpp files

    @oruebel
    oruebel committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    82a4c08 View commit details
    Browse the repository at this point in the history

  4. Moved read I/O classes to new ReadIO.hpp

    @oruebel
    oruebel committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6554e29 View commit details
    Browse the repository at this point in the history

  5. Refactor the read data wrappers to use a single ReadDataWrapper class… 

    … for both Attributes and Datasets
    @oruebel
    oruebel committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    bff7121 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Replace redundant ReadObjectType with StorageObjectType

    @oruebel
    oruebel committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    53365ff View commit details
    Browse the repository at this point in the history

  2. Add traits for ReadObjectWrapper to prevent instantiation for Group a… 

    …nd Undefined types
    @oruebel
    oruebel committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c66b3bc View commit details
    Browse the repository at this point in the history

  3. Fix formatting

    @oruebel
    oruebel committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    0da4800 View commit details
    Browse the repository at this point in the history

  4. Fix spelling error

    @oruebel
    oruebel committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d161c47 View commit details
    Browse the repository at this point in the history

  5. Inline functions in ReadIO.hpp

    @oruebel
    oruebel committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    58e5afb View commit details
    Browse the repository at this point in the history

  6. Some minor fixes

    @oruebel
    oruebel committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    b7cc149 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Merge branch 'main' into add_read

    @oruebel
    oruebel authored Sep 7, 2024
    Configuration menu
    Copy the full SHA
    b9c6c9b View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Update ElectrodGroup to provide standard Container constructor and mo… 

    …ve args to initalize
    @oruebel
    oruebel committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    69c3c4e View commit details
    Browse the repository at this point in the history

  2. Fix formatting

    @oruebel
    oruebel committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    e75c7ad View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Merge branch 'main' into add_read

    @oruebel
    oruebel committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5ab8464 View commit details
    Browse the repository at this point in the history

  2. Fix ElectricalSeries

    @oruebel
    oruebel committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    803dfcf View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Run test workflows on all PRs

    @oruebel
    oruebel committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    cdffc74 View commit details
    Browse the repository at this point in the history

  2. Fix static assert for ReadDataWrapper

    @oruebel
    oruebel committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    89f6d29 View commit details
    Browse the repository at this point in the history

  3. Sync add_read with main branch (#101) 

    * Merged main into add_read

* Fix docs build for SpikeEventSeries

* Fix code formatting

* Fix segfault due to duplicate declaration of NWBFile.io parameter
    @oruebel
    oruebel authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5608c5a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into add_read

    @oruebel
    oruebel committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c7ced4e View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Merge branch 'main' into add_read

    @oruebel
    oruebel committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    dd01ad3 View commit details
    Browse the repository at this point in the history

  2. Fix formatting and docs error after merge with main

    @oruebel
    oruebel committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    968fcf0 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Update docs/pages/userdocs/read.dox 

    Co-authored-by: Steph Prince <[email protected]>
    @oruebel @stephprince
    oruebel and stephprince authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    bfaabb8 View commit details
    Browse the repository at this point in the history

  2. Update src/io/ReadIO.hpp 

    Co-authored-by: Steph Prince <[email protected]>
    @oruebel @stephprince
    oruebel and stephprince authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a439212 View commit details
    Browse the repository at this point in the history

  3. Update src/io/ReadIO.hpp

    @oruebel
    oruebel authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5f28fb0 View commit details
    Browse the repository at this point in the history

  4. Rename ReadDataWrapper.is_dataset

    @oruebel
    oruebel committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a9725b2 View commit details
    Browse the repository at this point in the history

  5. Update src/io/hdf5/HDF5IO.hpp 

    Co-authored-by: Steph Prince <[email protected]>
    @oruebel @stephprince
    oruebel and stephprince authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e70949c View commit details
    Browse the repository at this point in the history

  6. Remove duplicate code in NWBFile

    @oruebel
    oruebel committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d1da5d1 View commit details
    Browse the repository at this point in the history

  7. Remove outdated ToDo item

    @oruebel
    oruebel committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    12a86a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Merge branch 'main' into add_read

    @oruebel
    oruebel committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ae66f33 View commit details
    Browse the repository at this point in the history

  2. Fix build error after merge

    @oruebel
    oruebel committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    69df3e0 View commit details
    Browse the repository at this point in the history