-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add read tests for TimeSeries
, VectorData,
Data,
ElementIdentifers,
Device`
#124
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## add_read #124 +/- ##
============================================
+ Coverage 90.87% 91.01% +0.13%
============================================
Files 53 53
Lines 3289 3349 +60
Branches 229 229
============================================
+ Hits 2989 3048 +59
- Misses 290 291 +1
Partials 10 10 ☔ View full report in Codecov by Sentry. |
…pecific write method from BaseIO to TimeSeries
@stephprince this PR is now ready for you to take a look at |
TimeSeries
TimeSeries
and VectorData
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added my review comments for the TimeSeries tests, but I have not gotten to the Vector Data or Table related changes yet
TimeSeries
and VectorData
TimeSeries
, VectorData,
Data,
ElementIdentifers,
Device`
Co-authored-by: Steph Prince <[email protected]>
Co-authored-by: Steph Prince <[email protected]>
Finished looking through the other files, other than the previous comments all looks good to me! |
Add unit tests for readfor
TimeSeries
For every neurodata_type we should test that: a) the type itself can be read from file, and b) that allDEFINE_FIELDS
specified for read can be read.TimeSeries
Fix #32 As part of writing the tests for TimeSeries, we should also double-check that all fields that AqNWB writes, that they are also exposed for read and that all types listed for read are also written.
TimeSeries.data.offset
attribute on writeTimeSeries.data.continuity
attribute on writecontrol
andcontrol_description
datasets on write (read viareadControlDescription
andreadControl
)starting_time
dataset and corresponding attributesunit
andrate
on write (read viareadStartingTime
,readStartingTimeUnit
,readStartingTimeRate
Fix #126 handling of
Data
andVectorData
:initalize()
methods forData
andVectorData
DynamicTable
andElectrodeTable
to callVectorData.initalize
instead of setting upVectorData
manuallyAdded write/read tests for additional types
VectorData
withint
,double
, andstring
dataData
with a single type (the remaining is covered by theVectorData
tests)ElementIdentifiers
and updated the class to overwrite thereadData
method to set the data type to int by defaultDevice
Additional fixes needed:
controlDescription
see Add read tests forTimeSeries
, VectorData,
Data,
ElementIdentifers,
Device` #124 (comment)