Add Eof Execution EIP-7692 (EIP-663, EIP-3540, EIP-3670, EIP-4200, EIP-4750, EIP-5450, EIP-6206, EIP-7069, EIP-7480, EIP-7620, EIP-7698, EIP-7756) #8176

benaadams · 2025-02-06T10:35:15Z

Closes #4584
Closes #4586
Closes #4906
Closes #4907
Closes #4956

Changes

- EOF Spec
- EOF EIPs listed as part of EIP-7692, namely:
  - EIP-663: SWAPN, DUPN and EXCHANGE instructions
  - EIP-3540: EOF - EVM Object Format v1
  - EIP-3670: EOF - Code Validation
  - EIP-4200: EOF - Static relative jumps
  - EIP-4750: EOF - Functions
  - EIP-5450: EOF - Stack Validation
  - EIP-6206: EOF - JUMPF and non-returning functions
  - EIP-7069: Revamped CALL instructions
  - EIP-7480: EOF - Data section access instructions
  - EIP-7620: EOF Contract Creation
  - EIP-7698: EOF - Creation transaction
  - EIP-7756: EOF/EVM Trace Specification
Refactor Evm to make it less unwieldy to opcode changes & optimizations

Types of changes

What types of changes does your code introduce?

New feature (a non-breaking change that adds functionality)

Testing

Requires testing

Yes

If yes, did you write tests?

Yes

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

Yes

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

Yes

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

* alot of fixes to stack validation and other fixes

- jump stack validation - Data opcodes (datacopy mistake in gas calculation

- new HeaderParsing Method (loop + swtich)

rubo · 2025-02-06T14:06:21Z

src/Nethermind/Directory.Packages.props

@@ -13,6 +13,7 @@
    <PackageVersion Include="BouncyCastle.Cryptography" Version="2.5.0" />
    <PackageVersion Include="Ckzg.Bindings" Version="2.0.1.1258" />
    <PackageVersion Include="Colorful.Console" Version="1.2.15" />
+    <PackageVersion Include="CommandLineParser" Version="2.9.1" />


This is redundant. We already use the same CLI parser for everything else.

Scooletz

A few remarks. I love both, the direction and the execution. Long live the delegate* calls!

Scooletz · 2025-02-07T12:57:52Z

src/Nethermind/Nethermind.Core/Specs/IReleaseSpec.cs

@@ -431,5 +437,9 @@ public interface IReleaseSpec : IEip1559Spec, IReceiptSpec
        bool IsAuthorizationListEnabled => IsEip7702Enabled;

        public bool RequestsEnabled => ConsolidationRequestsEnabled || WithdrawalRequestsEnabled || DepositsEnabled;
+
+        public object? EvmInstructions { get; set; }


Could we have some comments here? What kind of object is it etc?

Scooletz · 2025-02-07T12:58:06Z

src/Nethermind/Nethermind.Core/Specs/IReleaseSpec.cs

+
+        public object? EvmInstructions { get; set; }
+
+        public object? EvmTracedInstructions { get; set; }


Same as above? Maybe refer to Trace, NoTrace?

Scooletz · 2025-02-07T12:59:43Z

src/Nethermind/Nethermind.Core/Transaction.cs

@@ -20,6 +20,7 @@ namespace Nethermind.Core
    [DebuggerDisplay("{Hash}, Value: {Value}, To: {To}, Gas: {GasLimit}")]
    public class Transaction
    {
+        public byte[] EofMagic = [0xEF, 0x00];


Suggested change

public byte[] EofMagic = [0xEF, 0x00];

public static ReadOnlyMemory<byte> EofMagic => [0xEF, 0x00];

stuff?

Scooletz · 2025-02-07T13:00:53Z

src/Nethermind/Nethermind.Evm/AddressExtensions.cs

-            deployingAddress.Bytes.CopyTo(bytes.Slice(1, 20));
-            salt.CopyTo(bytes.Slice(21, salt.Length));
-            ValueKeccak.Compute(initCode).BytesAsSpan.CopyTo(bytes.Slice(21 + salt.Length, 32));
+            deployingAddress.Bytes.CopyTo(bytes.Slice(1, Address.Size));


Thank you for removing magic 🙇

Scooletz · 2025-02-07T13:05:25Z

src/Nethermind/Nethermind.Evm/CodeAnalysis/JumpDestinationAnalyzer.cs

-            }
+    private static void WaitForAnalysisToComplete(ManualResetEventSlim resetEvent)
+    {
+        Thread thread = Thread.CurrentThread;


There was the scoping mechanism elsewhere. Can't we do using var priority = ... here?

Scooletz · 2025-02-07T13:51:17Z

src/Nethermind/Nethermind.Evm/Instructions/EvmInstructions.cs

+
+        for (int i = 0; i < lookup.Length; i++)
+        {
+            lookup[i] = &InstructionBadInstruction;


Scooletz · 2025-02-07T13:51:49Z

src/Nethermind/Nethermind.Evm/Instructions/EvmInstructions.cs

+        lookup[(int)Instruction.BYTE] = &InstructionByte;
+
+        // Conditional: enable shift opcodes if the spec allows.
+        if (spec.ShiftOpcodesEnabled)


Are you saying you extracted all spec checks? ❤️

Scooletz · 2025-02-07T13:54:48Z

src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs

                            _codeInfoRepository.InsertCode(WorldState, code, env.ExecutingAccount, spec);

                            unspentGas -= codeDepositGasCost;
                        }
                    }

+                    if (tx.IsEofContractCreation)


Extract method? Gets really big.

Scooletz · 2025-02-07T13:55:52Z

src/Nethermind/Nethermind.Evm/TypeFlags.cs

+
+namespace Nethermind.Evm;
+
+public interface IFlag


As you generalized on/off using generic parameter trick, should it be commented for future generations how and why to use it?

Scooletz · 2025-02-07T13:59:36Z

src/Nethermind/Nethermind.Evm/VirtualMachine.cs

+                debugger?.TryWait(ref _vmState, ref programCounter, ref gasAvailable, ref stack.Head);
+#endif
+                // Fetch the current instruction from the code section.
+                Instruction instruction = codeSection[programCounter];


I'm not sure this can be trusted. You removed so much of the beautiful code that was here and all we're left is an array lookup... On a serious note: beautiful 😍

Demuirgos and others added 30 commits June 25, 2024 01:01

* (temporary) added prague pyspec tests suite

cc5961a

* alot of fixes to stack validation and other fixes

fix some failing tests :

765aed3

- jump stack validation - Data opcodes (datacopy mistake in gas calculation

reimplement *CALL opcodes

0112f8b

Merged master

5aa20d4

Minor code changes

7bb0958

added status error codes

6b28af5

fix some failing tests

71f7de1

Merge remote-tracking branch 'origin/master' into feature/evm/eof

4d336ce

removing unused code

522bff7

some refactor

529ea09

Formatting

e5e88e1

Fix enablement bracketing logic

10ce03b

Clean up, fix if bracketing

b628386

Return 1 for non-eof contract don't charge call gas

b26fb9a

Only available in EOF

961609a

Return statuscode should continue

1d57470

Check stack returns

a815169

Handle ArrayPool arrays more safely

486e619

Fix out of bounds vector access

b4f1475

Added comments, and fixed bugs

b037ba8

fix unreachable code check

2765ac0

Add more validation rules for EOFCREATE and RETURNCONTRACT

68cfba3

Formatting

bdbb912

Merge remote-tracking branch 'origin/master' into feature/evm/eof

259711b

- some EofCreate/ReturnContract fixes

151398f

- new HeaderParsing Method (loop + swtich)

some refactors to CodeInfo and EofCodeInfo

e684eff

Merge remote-tracking branch 'origin/master' into feature/evm/eof

3aba7de

formatting

103f834

Merge branch 'master' into feature/evm/eof

8c81d45

Increment Nonce before snapshot

e4b2ca6

benaadams added 10 commits February 5, 2025 19:46

Improve

b14808e

More lazy

9cd3b37

Others

758d101

Refatcor

e9fcdb1

Tidy up

aef435b

Refactor

025506f

Tidy up

36fb787

tidy up

a0fac5a

Refactor

df45003

readonly struct

97b4d08

benaadams added this to the Fuska HardFork milestone Feb 6, 2025

benaadams added eip epic fusaka evm performance is good labels Feb 6, 2025

benaadams assigned benaadams and Demuirgos Feb 6, 2025

benaadams mentioned this pull request Feb 6, 2025

Add Eof Execution EIP-7692 (EIP-663, EIP-3540, EIP-3670, EIP-4200, EIP-4750, EIP-5450, EIP-6206, EIP-7069, EIP-7480, EIP-7620, EIP-7698, EIP-7756) #6896

Closed

5 tasks

benaadams added 3 commits February 6, 2025 13:08

Tidy up

20da4b1

Merge branch 'master' into feature/evm/eof

6d2415b

Merge branch 'master' into feature/evm/eof

f987ef9

LukaszRozmej requested review from LukaszRozmej, smartprogrammer93 and Demuirgos February 6, 2025 13:37

rubo reviewed Feb 6, 2025

View reviewed changes

benaadams added the pleasure to code label Feb 6, 2025

benaadams requested a review from Scooletz February 6, 2025 14:41

MarekM25 self-requested a review February 6, 2025 17:16

Scooletz reviewed Feb 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Eof Execution EIP-7692 (EIP-663, EIP-3540, EIP-3670, EIP-4200, EIP-4750, EIP-5450, EIP-6206, EIP-7069, EIP-7480, EIP-7620, EIP-7698, EIP-7756) #8176

Add Eof Execution EIP-7692 (EIP-663, EIP-3540, EIP-3670, EIP-4200, EIP-4750, EIP-5450, EIP-6206, EIP-7069, EIP-7480, EIP-7620, EIP-7698, EIP-7756) #8176

benaadams commented Feb 6, 2025

rubo Feb 6, 2025

Scooletz left a comment

Scooletz Feb 7, 2025

Scooletz Feb 7, 2025

Scooletz Feb 7, 2025

Scooletz Feb 7, 2025

Scooletz Feb 7, 2025

Scooletz Feb 7, 2025

Scooletz Feb 7, 2025

Scooletz Feb 7, 2025

Scooletz Feb 7, 2025

Scooletz Feb 7, 2025


		public object? EvmInstructions { get; set; }

		public object? EvmTracedInstructions { get; set; }

	public byte[] EofMagic = [0xEF, 0x00];
	public static ReadOnlyMemory<byte> EofMagic => [0xEF, 0x00];

Add Eof Execution EIP-7692 (EIP-663, EIP-3540, EIP-3670, EIP-4200, EIP-4750, EIP-5450, EIP-6206, EIP-7069, EIP-7480, EIP-7620, EIP-7698, EIP-7756) #8176

Are you sure you want to change the base?

Add Eof Execution EIP-7692 (EIP-663, EIP-3540, EIP-3670, EIP-4200, EIP-4750, EIP-5450, EIP-6206, EIP-7069, EIP-7480, EIP-7620, EIP-7698, EIP-7756) #8176

Conversation

benaadams commented Feb 6, 2025

Changes

Types of changes

What types of changes does your code introduce?

Testing

Requires testing

If yes, did you write tests?

Notes on testing

Documentation

Requires documentation update

Requires explanation in Release Notes

Remarks

Choose a reason for hiding this comment

Scooletz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment