This repository has been archived by the owner on May 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 69
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use the GRPC assistant API in ClusterMembership client/server (#1251)
* Use the GRPC assistant API in ClusterMembership client/server * Code review requests
- Loading branch information
tbak
authored
Apr 7, 2022
1 parent
083db0e
commit 74de0bf
Showing
16 changed files
with
355 additions
and
130 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
127 changes: 127 additions & 0 deletions
127
...va/com/netflix/titus/client/clustermembership/resolver/SimpleClusterMembershipClient.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| /* | ||
| * Copyright 2022 Netflix, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.netflix.titus.client.clustermembership.resolver; | ||
|
|
||
| import com.google.protobuf.Empty; | ||
| import com.netflix.titus.client.clustermembership.grpc.ClusterMembershipClient; | ||
| import com.netflix.titus.grpc.protogen.ClusterMembershipEvent; | ||
| import com.netflix.titus.grpc.protogen.ClusterMembershipRevision; | ||
| import com.netflix.titus.grpc.protogen.ClusterMembershipRevisions; | ||
| import com.netflix.titus.grpc.protogen.ClusterMembershipServiceGrpc; | ||
| import com.netflix.titus.grpc.protogen.ClusterMembershipServiceGrpc.ClusterMembershipServiceStub; | ||
| import com.netflix.titus.grpc.protogen.DeleteMemberLabelsRequest; | ||
| import com.netflix.titus.grpc.protogen.EnableMemberRequest; | ||
| import com.netflix.titus.grpc.protogen.MemberId; | ||
| import com.netflix.titus.grpc.protogen.UpdateMemberLabelsRequest; | ||
| import io.grpc.ManagedChannel; | ||
| import io.grpc.stub.StreamObserver; | ||
| import reactor.core.publisher.Flux; | ||
| import reactor.core.publisher.Mono; | ||
| import reactor.core.publisher.MonoSink; | ||
|
|
||
| /** | ||
| * FIXME We need this implementation for testing as DefaultClusterMembershipClient is located in titus-common-server package. | ||
| * To resolve this issue we have to move CallMetadata classes to titus-common-client. | ||
| */ | ||
| class SimpleClusterMembershipClient implements ClusterMembershipClient { | ||
|
|
||
| private final ManagedChannel channel; | ||
| private final ClusterMembershipServiceStub stub; | ||
|
|
||
| public SimpleClusterMembershipClient(ManagedChannel channel) { | ||
| this.channel = channel; | ||
| this.stub = ClusterMembershipServiceGrpc.newStub(channel); | ||
| } | ||
|
|
||
| @Override | ||
| public Mono<ClusterMembershipRevisions> getMembers() { | ||
| return Mono.create(sink -> stub.getMembers(Empty.getDefaultInstance(), connectSink(sink))); | ||
| } | ||
|
|
||
| @Override | ||
| public Mono<ClusterMembershipRevision> getMember(MemberId request) { | ||
| return Mono.create(sink -> stub.getMember(request, connectSink(sink))); | ||
| } | ||
|
|
||
| @Override | ||
| public Mono<ClusterMembershipRevision> updateMemberLabels(UpdateMemberLabelsRequest request) { | ||
| return Mono.create(sink -> stub.updateMemberLabels(request, connectSink(sink))); | ||
| } | ||
|
|
||
| @Override | ||
| public Mono<ClusterMembershipRevision> deleteMemberLabels(DeleteMemberLabelsRequest request) { | ||
| return Mono.create(sink -> stub.deleteMemberLabels(request, connectSink(sink))); | ||
| } | ||
|
|
||
| @Override | ||
| public Mono<ClusterMembershipRevision> enableMember(EnableMemberRequest request) { | ||
| return Mono.create(sink -> stub.enableMember(request, connectSink(sink))); | ||
| } | ||
|
|
||
| @Override | ||
| public Mono<Void> stopBeingLeader() { | ||
| return Mono.<Empty>create(sink -> stub.stopBeingLeader(Empty.getDefaultInstance(), connectSink(sink))) | ||
| .ignoreElement() | ||
| .cast(Void.class); | ||
| } | ||
|
|
||
| @Override | ||
| public Flux<ClusterMembershipEvent> events() { | ||
| return Flux.create(sink -> { | ||
| stub.events(Empty.getDefaultInstance(), new StreamObserver<ClusterMembershipEvent>() { | ||
| @Override | ||
| public void onNext(ClusterMembershipEvent value) { | ||
| sink.next(value); | ||
| } | ||
|
|
||
| @Override | ||
| public void onError(Throwable t) { | ||
| sink.error(t); | ||
| } | ||
|
|
||
| @Override | ||
| public void onCompleted() { | ||
| sink.complete(); | ||
| } | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| @Override | ||
| public void shutdown() { | ||
| channel.shutdownNow(); | ||
| } | ||
|
|
||
| private <T> StreamObserver<T> connectSink(MonoSink<T> sink) { | ||
| return new StreamObserver<T>() { | ||
| @Override | ||
| public void onNext(T value) { | ||
| sink.success(value); | ||
| } | ||
|
|
||
| @Override | ||
| public void onError(Throwable t) { | ||
| sink.error(t); | ||
| } | ||
|
|
||
| @Override | ||
| public void onCompleted() { | ||
| sink.success(); | ||
| } | ||
| }; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
...main/java/com/netflix/titus/runtime/clustermembership/DefaultClusterMembershipClient.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| /* | ||
| * Copyright 2022 Netflix, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.netflix.titus.runtime.clustermembership; | ||
|
|
||
| import com.google.protobuf.Empty; | ||
| import com.netflix.titus.client.clustermembership.grpc.ClusterMembershipClient; | ||
| import com.netflix.titus.common.util.ExceptionExt; | ||
| import com.netflix.titus.grpc.protogen.ClusterMembershipEvent; | ||
| import com.netflix.titus.grpc.protogen.ClusterMembershipRevision; | ||
| import com.netflix.titus.grpc.protogen.ClusterMembershipRevisions; | ||
| import com.netflix.titus.grpc.protogen.ClusterMembershipServiceGrpc; | ||
| import com.netflix.titus.grpc.protogen.ClusterMembershipServiceGrpc.ClusterMembershipServiceStub; | ||
| import com.netflix.titus.grpc.protogen.DeleteMemberLabelsRequest; | ||
| import com.netflix.titus.grpc.protogen.EnableMemberRequest; | ||
| import com.netflix.titus.grpc.protogen.MemberId; | ||
| import com.netflix.titus.grpc.protogen.UpdateMemberLabelsRequest; | ||
| import com.netflix.titus.runtime.endpoint.common.grpc.assistant.GrpcClientCallAssistant; | ||
| import com.netflix.titus.runtime.endpoint.common.grpc.assistant.GrpcClientCallAssistantFactory; | ||
| import io.grpc.ManagedChannel; | ||
| import reactor.core.publisher.Flux; | ||
| import reactor.core.publisher.Mono; | ||
|
|
||
| public class DefaultClusterMembershipClient implements ClusterMembershipClient { | ||
|
|
||
| private final GrpcClientCallAssistant<ClusterMembershipServiceStub> assistant; | ||
| private final ManagedChannel managedChannel; | ||
|
|
||
| public DefaultClusterMembershipClient(GrpcClientCallAssistantFactory assistantFactory, | ||
| ManagedChannel managedChannel) { | ||
| this.managedChannel = managedChannel; | ||
| this.assistant = assistantFactory.create(ClusterMembershipServiceGrpc.newStub(managedChannel)); | ||
| } | ||
|
|
||
| @Override | ||
| public Mono<ClusterMembershipRevisions> getMembers() { | ||
| return assistant.asMono((stub, responseStream) -> stub.getMembers(Empty.getDefaultInstance(), responseStream)); | ||
| } | ||
|
|
||
| @Override | ||
| public Mono<ClusterMembershipRevision> getMember(MemberId request) { | ||
| return assistant.asMono((stub, responseStream) -> stub.getMember(request, responseStream)); | ||
| } | ||
|
|
||
| @Override | ||
| public Mono<ClusterMembershipRevision> updateMemberLabels(UpdateMemberLabelsRequest request) { | ||
| return assistant.asMono((stub, responseStream) -> stub.updateMemberLabels(request, responseStream)); | ||
| } | ||
|
|
||
| @Override | ||
| public Mono<ClusterMembershipRevision> deleteMemberLabels(DeleteMemberLabelsRequest request) { | ||
| return assistant.asMono((stub, responseStream) -> stub.deleteMemberLabels(request, responseStream)); | ||
| } | ||
|
|
||
| @Override | ||
| public Mono<ClusterMembershipRevision> enableMember(EnableMemberRequest request) { | ||
| return assistant.asMono((stub, responseStream) -> stub.enableMember(request, responseStream)); | ||
| } | ||
|
|
||
| @Override | ||
| public Mono<Void> stopBeingLeader() { | ||
| return assistant.asMonoEmpty((stub, responseStream) -> stub.stopBeingLeader(Empty.getDefaultInstance(), responseStream)); | ||
| } | ||
|
|
||
| @Override | ||
| public Flux<ClusterMembershipEvent> events() { | ||
| return assistant.asFlux((stub, responseStream) -> stub.events(Empty.getDefaultInstance(), responseStream)); | ||
| } | ||
|
|
||
| @Override | ||
| public void shutdown() { | ||
| ExceptionExt.silent(managedChannel::shutdownNow); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.