image sanitizer failing job creation on unknown errors (#1230)

Job Image sanitizer fix
Netflix · Mar 11, 2022 · 1361c6b · 1361c6b
1 parent 1939e3a
commit 1361c6b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/...ay/src/test/java/com/netflix/titus/gateway/service/v3/internal/JobImageSanitizerTest.java b/...ay/src/test/java/com/netflix/titus/gateway/service/v3/internal/JobImageSanitizerTest.java
@@ -117,6 +117,16 @@ public void testSuppressedInternalError() {
                 .verifyComplete();
     }
 
+    @Test
+    public void testRegistryRuntimeError() {
+        when(registryClient.getImageDigest(anyString(), anyString()))
+                .thenReturn(Mono.error(new RuntimeException("Unable to reach the registry")));
+
+        StepVerifier.create(sanitizer.sanitizeAndApply(jobDescriptorWithTag))
+                .expectError(IllegalArgumentException.class)
+                .verify();
+    }
+
     @Test
     public void testJobWithDigestExists() {
         Image image = jobDescriptorWithDigest.getContainer().getImage();

diff --git a/...runtime/src/main/java/com/netflix/titus/runtime/endpoint/admission/JobImageSanitizer.java b/...runtime/src/main/java/com/netflix/titus/runtime/endpoint/admission/JobImageSanitizer.java
@@ -130,7 +130,8 @@ private boolean isAllowedException(Throwable throwable, Image image) {
                 imageResource,
                 throwable.getClass().getSimpleName()
         );
-        return true;
+        // unknown errors should prevent job creation
+        return false;
     }
 
     @SuppressWarnings("unchecked")