Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

added support for newer jackson version in client #2079

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

apanicker-nflx
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #2079 (c3cd522) into dev (989a881) will decrease coverage by 0.10%.
The diff coverage is 25.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2079      +/-   ##
============================================
- Coverage     65.77%   65.66%   -0.11%     
+ Complexity     3968     3967       -1     
============================================
  Files           301      301              
  Lines         18597    18601       +4     
  Branches       1706     1708       +2     
============================================
- Hits          12232    12215      -17     
- Misses         5522     5539      +17     
- Partials        843      847       +4     
Impacted Files Coverage Δ Complexity Δ
.../com/netflix/conductor/client/http/ClientBase.java 50.00% <25.00%> (-0.68%) 23.00 <1.00> (+1.00) ⬇️
...ductor/dao/cassandra/CassandraEventHandlerDAO.java 65.78% <0.00%> (-10.53%) 15.00% <0.00%> (ø%)
...x/conductor/common/metadata/tasks/TaskExecLog.java 80.95% <0.00%> (-4.77%) 11.00% <0.00%> (-1.00%)
.../conductor/dao/cassandra/CassandraMetadataDAO.java 53.88% <0.00%> (-4.15%) 24.00% <0.00%> (ø%)
...e/execution/tasks/SystemTaskWorkerCoordinator.java 81.25% <0.00%> (-2.09%) 17.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 989a881...c3cd522. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5043

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.09%) to 70.254%

Changes Missing Coverage Covered Lines Changed/Added Lines %
client/src/main/java/com/netflix/conductor/client/http/ClientBase.java 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraEventHandlerDAO.java 8 68.42%
cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java 8 55.44%
Totals Coverage Status
Change from base Build 5027: -0.09%
Covered Lines: 13068
Relevant Lines: 18601

💛 - Coveralls

@apanicker-nflx apanicker-nflx merged commit f515e0c into dev Feb 11, 2021
@apanicker-nflx apanicker-nflx deleted the jackson_version_client branch February 11, 2021 02:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants