spectator-go design considerations #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add advice for reporting intervals for high-volume operations.
brharrington
reviewed
Sep 4, 2024
| This client is stateless, and sends a UDP packet (or unixgram) to `spectatord` each time a meter is | ||
| updated. If you are performing high-volume operations, on the order of tens-of-thousands or millions | ||
| of operations per second, then you should pre-aggregate your metrics and report them at a cadence | ||
| closer to the `spectatord` publish interval of 5 seconds, or the Atlas metrics granularity of 1 minute. |
There was a problem hiding this comment.
Given that high resolution streaming is gaining more usage, I would omit the 1m part and just advise to batch and send every ~5s.
There was a problem hiding this comment.
Batching as a feature is not yet available in spectator-go, but it will be added before the end of the quarter.
Good point on the timing aspect, though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add advice for reporting intervals for high-volume operations.