do not set sys.time.estimatedError when time is unsynchronized #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copperlight
force-pushed
the
fix-time-error
branch
2 times, most recently
from
ea83ac7 to
6dabf95
Compare
We are trying to gather some data on the accuracy of clock time across the fleet, and the `sys.time.estimatedError` was reporting a number of 16s values. These values occur when the kernel has not synchonized the clock yet. This fact is tracked with the `sys.time.unsynchronized` metric. The `estimatedError` metric should only have valid results from `ntp_adjtime`.
copperlight
force-pushed
the
fix-time-error
branch
from
bc9521e to
33e9ce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to gather some data on the accuracy of clock time across the fleet, and the
sys.time.estimatedErrorwas reporting a number of 16s values.These values occur when the kernel has not synchonized the clock yet. This fact is tracked with the
sys.time.unsynchronizedmetric. TheestimatedErrormetric should only have valid results fromntp_adjtime.