Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates header #19

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Updates header #19

merged 3 commits into from
Dec 10, 2024

Conversation

dragoss-nc
Copy link
Collaborator

@dragoss-nc dragoss-nc linked an issue Dec 9, 2024 that may be closed by this pull request
Header #5
Closed
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 9, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 9, 2024 •
edited
Loading

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

kesiah
kesiah requested changes Dec 9, 2024
View reviewed changes
blocks/header/header.css Show resolved Hide resolved
blocks/header/header.css Outdated Show resolved Hide resolved
blocks/header/header.css Outdated Show resolved Hide resolved
@dragoss-nc dragoss-nc requested a review from kesiah December 10, 2024 09:17
kesiah
kesiah approved these changes Dec 10, 2024
View reviewed changes
blocks/header/header.js
@@ -117,6 +117,7 @@ export default async function decorate(block) {
block.textContent = '';
const nav = document.createElement('nav');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use createElement function from common and you can send class names and other properties ;)

@dragoss-nc dragoss-nc merged commit 8aa01ea into main Dec 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesiah kesiah kesiah approved these changes

@VadimMikh VadimMikh Awaiting requested review from VadimMikh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header
2 participants
@dragoss-nc @kesiah