Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 style buttons #12

Merged
merged 7 commits into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions icons/arrow-right.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/calendar.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/chevron-right.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/download.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
25 changes: 16 additions & 9 deletions scripts/aem.js
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ function decorateButtons(element) {
&& twoup.childNodes.length === 1
&& twoup.tagName === 'P'
) {
a.className = 'button primary';
a.className = 'button button--secondary';
twoup.classList.add('button-container');
}
if (
Expand All @@ -412,7 +412,7 @@ function decorateButtons(element) {
&& twoup.childNodes.length === 1
&& twoup.tagName === 'P'
) {
a.className = 'button secondary';
a.className = 'button button--tertiary';
twoup.classList.add('button-container');
}
}
Expand All @@ -426,16 +426,23 @@ function decorateButtons(element) {
* @param {string} [prefix] prefix to be added to icon src
* @param {string} [alt] alt text to be added to icon
*/
function decorateIcon(span, prefix = '', alt = '') {
async function decorateIcon(span, prefix = '', alt = '') {
const iconName = Array.from(span.classList)
.find((c) => c.startsWith('icon-'))
.substring(5);
const img = document.createElement('img');
img.dataset.iconName = iconName;
img.src = `${window.hlx.codeBasePath}${prefix}/icons/${iconName}.svg`;
img.alt = alt;
img.loading = 'lazy';
span.append(img);

const resp = await fetch(`${window.hlx.codeBasePath}${prefix}/icons/${iconName}.svg`);
kesiah marked this conversation as resolved.
Show resolved Hide resolved
if (resp.ok) {
const iconHTML = await resp.text();
if (iconHTML.match(/<style/i)) {
const img = document.createElement('img');
img.alt = alt;
img.src = `data:image/svg+xml,${encodeURIComponent(iconHTML)}`;
span.appendChild(img);
} else {
span.innerHTML = iconHTML;
}
}
}

/**
Expand Down
121 changes: 92 additions & 29 deletions styles/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
--hl22-line-height: 160%;
--txt150-font-size: 14px;
--txt150-line-height: 114%;
--txt150-font-weight: bold;
--txt150-font-weight: 700;
--txt201-font-size: 16px;
--txt201-line-height: 160%;
--txt204-font-size: 14px;
Expand Down Expand Up @@ -270,66 +270,129 @@ a:hover {
text-decoration: underline;
}

.icon {
display: inline-block;
}

.icon svg {
fill: currentcolor;
}

/* buttons */
a.button:any-link,
button {
--button-bg-color: var(--col-brand30);
--button-border-color: var(--col-brand30);
--button-border-width: 1px;
--button-text-color: var(--col-white);
--button-icon-color: var(--button-text-color);
--button-vertical-padding: 12px;
--button-horitzontal-padding: 16px;

box-sizing: border-box;
display: inline-block;
display: inline-flex;
align-items: center;
gap: 8px;
max-width: 100%;
margin: 12px 0;
border: 2px solid transparent;
border-radius: 2.4em;
padding: 0.5em 1.2em;
font-family: var(--body-font-family);
font-style: normal;
font-weight: 500;
line-height: 1.25;
font-size: var(--txt150-font-size);
line-height: var(--txt150-line-height);
font-weight: var(--txt150-font-weight);
text-align: center;
text-decoration: none;
background-color: var(--link-color);
color: var(--background-color);
color: var(--button-text-color);
cursor: pointer;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;

/* stylelint-disable-next-line no-descending-specificity */
.icon {
color: var(--button-icon-color);
}
}

a.button:hover,
a.button:focus,
button:hover,
button:focus {
background-color: var(--link-hover-color);
--button-bg-color: var(--col-brand50);
--button-border-color: var(--col-brand50);

cursor: pointer;
}

a.button:any-link:not(.button--tertiary),
button:not(.button--tertiary) {
border-radius: 2px;
border: var(--button-border-width) solid var(--button-border-color);
padding: var(--button-vertical-padding) var(--button-horitzontal-padding);
background-color: var(--button-bg-color);
min-height: 48px;
}

button:disabled,
button:disabled:hover {
background-color: var(--light-neutral-color);
--button-bg-color: var(--col-neutral30);
--button-border-color: var(--col-neutral30);
--button-text-color: var(--col-white);

cursor: unset;
}

a.button.secondary,
button.secondary {
background-color: unset;
border: 2px solid currentcolor;
color: var(--text-color);
a.button.button--secondary,
button.button--secondary {
--button-bg-color: var(--col-white);
--button-border-color: var(--col-neutral90);
--button-text-color: var(--col-neutral90);
--button-icon-color: var(--col-brand40);

&:hover,
&:focus {
--button-border-width: 2px;
--button-vertical-padding: 11px;
--button-horitzontal-padding: 15px;
}
}

main img {
max-width: 100%;
width: auto;
height: auto;
button.button--secondary:disabled,
button.button--secondary:disabled:hover {
--button-border-color: var(--col-neutral30);
--button-text-color: var(--col-neutral30);
--button-icon-color: var(--col-neutral30);
}

.icon {
display: inline-block;
height: 24px;
width: 24px;
a.button.button--tertiary,
button.button--tertiary {
--button-bg-color: var(--col-white);
--button-border-color: var(--col-neutral90);
--button-text-color: var(--col-neutral90);
--button-icon-color: var(--col-brand40);

font-style: normal;
padding-block-end: 3px;

&:hover,
&:focus {
--button-vertical-padding: 11px;
--button-horitzontal-padding: 15px;

border-width: 2px;
text-decoration: underline;
text-underline-offset: 5px;
}
}

button.button--tertiary:disabled,
button.button--tertiary:disabled:hover {
--button-text-color: var(--col-neutral30);
--button-icon-color: var(--col-neutral30);
}

.icon img {
height: 100%;
width: 100%;
main img {
max-width: 100%;
width: auto;
height: auto;
}

main {
Expand Down
Loading