Adds changes based on code review

Netcentric · Dec 10, 2024 · 4ffbc93 · 4ffbc93
1 parent 57969d7
commit 4ffbc93
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/blocks/header/header.css b/blocks/header/header.css
@@ -15,8 +15,7 @@ header {
   }
 }
 
-nav {
-  box-sizing: border-box;
+.nav {
   display: grid;
   grid-template:
     'hamburger brand tools' var(--nav-height)
@@ -29,6 +28,12 @@ nav {
   padding-inline: var(--content-padding-inline);
   font-family: var(--body-font-family);
 
+  @media (min-width: 1280px) {
+    display: flex;
+    justify-content: space-between;
+    gap: 0 32px;
+  }
+
   &[aria-expanded='true'] {
     grid-template:
       'hamburger brand' var(--nav-height)
@@ -43,12 +48,6 @@ nav {
     }
   }
 
-  @media (min-width: 1280px) {
-    display: flex;
-    justify-content: space-between;
-    gap: 0 32px;
-  }
-
   p {
     margin: 0;
     line-height: 1;

diff --git a/blocks/header/header.js b/blocks/header/header.js
@@ -117,6 +117,7 @@ export default async function decorate(block) {
   block.textContent = '';
   const nav = document.createElement('nav');
   nav.id = 'nav';
+  nav.classList.add('nav');
   while (fragment.firstElementChild) nav.append(fragment.firstElementChild);
 
   const classes = ['brand', 'sections', 'tools'];