Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kaw 7685 columns #4

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Kaw 7685 columns #4

merged 2 commits into from
Jul 25, 2024

Conversation

TomaszDziezykNetcentric
Copy link
Contributor

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #KAW-7685

Test URLs:

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jul 24, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jul 24, 2024

Page Scores Audits Google
/drafts/tdziezyk/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

lakshmishriaswathnarayana
lakshmishriaswathnarayana requested changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@lakshmishriaswathnarayana lakshmishriaswathnarayana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-07-25 at 09 29 12

Images look stretched for screen size less than 760, can you check ?

@TomaszDziezykNetcentric
Copy link
Contributor Author

TomaszDziezykNetcentric commented Jul 25, 2024 •
edited
Loading

Screenshot 2024-07-25 at 09 29 12

Images look stretched for screen size less than 760, can you check ?

I used assets with better resolution.

obraz

@lakshmishriaswathnarayana lakshmishriaswathnarayana merged commit 6d66fc6 into main Jul 25, 2024
2 checks passed
@lakshmishriaswathnarayana lakshmishriaswathnarayana deleted the KAW-7685-columns branch July 25, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lakshmishriaswathnarayana lakshmishriaswathnarayana Awaiting requested review from lakshmishriaswathnarayana

Assignees

@TomaszDziezykNetcentric TomaszDziezykNetcentric

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomaszDziezykNetcentric @lakshmishriaswathnarayana