permit specifying daemonset and deployment resources #930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
permit specifying trident-controller deployment and trident-node-linux daemonset container resource requests/limits in the TridentOrchestrator spec.
Did you add unit tests? Why not?
Yes, for both modifications of the deployment and daemonset
Does this code need functional testing?
No, I have already tested the functionality locally, and the following works:
daemonsetResources
(or specyifying a{}
), in which case all containers are configures with aresources: {}
spec.TridentOrchestrator
spec, in which case trident-orchestrator correctly reports that the configuration is not readable.Is a code review walkthrough needed? why or why not?
Probably needed, I'm typically not sure whether my modifications to
types.go
file needs some autogen of some sort.Should additional test coverage be executed in addition to pre-merge?
don't think so
Does this code need a note in the changelog?
permit specyfing daemonset and deployment resource requests and limits.
Does this code require documentation changes?
don't think so
Additional Information
I was sure whether I should offer the ability to specify the resources for each container of the deployment/daemonset. that would probably amount to 6-7 resources spec, let me know if you want me to implement that.
closes #853