Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No limits or requests set on Trident resources #853

Open
cjreyn opened this issue Aug 16, 2023 · 3 comments · May be fixed by #930
Open

No limits or requests set on Trident resources #853

cjreyn opened this issue Aug 16, 2023 · 3 comments · May be fixed by #930
Labels
enhancement tracked

Comments

@cjreyn
Copy link

cjreyn commented Aug 16, 2023 •
edited
Loading

Describe the bug
No limits or requests are set for any Trident pods except the operator pod. This is bad practice, as an issue in Trident could take down the cluster.

Environment
Provide accurate information about the environment to help us reproduce the issue.

  • Trident version: 23.07
  • Trident installation flags used: none
  • Container runtime: containerd 1.6.6-3.1
  • Kubernetes version: 1.25.9
  • Kubernetes orchestrator: kubeadm
  • Kubernetes enabled feature gates: na
  • OS: RHEL8
  • NetApp backend types: ONTAP AFF
  • Other:

To Reproduce
Install trident with the helm chart. Query the daemonset named "daemonset.apps/trident-node-linux" and all pods it starts. No sign of limits or requests.

Expected behavior
The daemonset should set some sensible cpu, mem, and ephemeral storage limits and requests.

Additional context
Add any other context about the problem here.
@cjreyn cjreyn added the bug label Aug 16, 2023
@m0untains
Copy link

We bumped into this issue as well, as we have a number of cluster policies (i.e. kyverno) for enforcing various standards around how resources and limits are set across the cluster.

It would be great if the helm chart let us specify (override) the resource block for each pod deployed (i.e. app, daemonset, and all sidecars). This flexibility is a fairly common paradigm across the k8s helm ecosystem, so we were surprised to not find it here.

clementnuss added a commit to clementnuss/trident that referenced this issue Sep 27, 2024
@clementnuss
permit specifying daemonset and deployment resources
9b95595 
closes NetApp#853

Signed-off-by: Clément Nussbaumer <[email protected]>
clementnuss added a commit to clementnuss/trident that referenced this issue Sep 27, 2024
@clementnuss
permit specifying daemonset and deployment resources
1ef132c 
closes NetApp#853

Signed-off-by: Clément Nussbaumer <[email protected]>
@clementnuss clementnuss linked a pull request Sep 27, 2024 that will close this issue
Open
clementnuss added a commit to clementnuss/trident that referenced this issue Oct 17, 2024
@clementnuss
permit specifying daemonset and deployment resources
0169eb0 
closes NetApp#853

Signed-off-by: Clément Nussbaumer <[email protected]>
clementnuss added a commit to clementnuss/trident that referenced this issue Oct 17, 2024
@clementnuss
permit specifying daemonset and deployment resources
3ced964 
closes NetApp#853

Signed-off-by: Clément Nussbaumer <[email protected]>
@sjpeeris
Copy link
Collaborator

Hi @cjreyn Please let us know if this issue still exists with the newer versions of Trident. If this has been resolved, please close the issue.

@cjreyn
Copy link
Author

cjreyn commented Oct 30, 2024

Thanks for addressing! I'll wait for it to trickle into a tagged release unless I find time to roll out the fixed branch on our test cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

permit specifying daemonset and deployment resources clementnuss/trident
3 participants
@m0untains @cjreyn @sjpeeris