-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Resource]: Ethernet Port #334
Open
acch
wants to merge
16
commits into
NetApp:integration/main
Choose a base branch
from
acch:304-ethernet-port-resource
base: integration/main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
acch
force-pushed
the
304-ethernet-port-resource
branch
from
November 13, 2024 10:47
402e912
to
4eefd5c
Compare
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
acch
force-pushed
the
304-ethernet-port-resource
branch
from
November 18, 2024 15:29
29b6f47
to
aa01b4d
Compare
Signed-off-by: Achim Christ <[email protected]>
… methods Signed-off-by: Achim Christ <[email protected]>
acch
force-pushed
the
304-ethernet-port-resource
branch
from
November 19, 2024 13:57
6655765
to
8b6ca49
Compare
Signed-off-by: Achim Christ <[email protected]>
…tes without requiring refresh Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
acch
requested review from
carchi8py,
chuyich,
suhasbshekar and
wenjun666
as code owners
November 20, 2024 10:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to create ethernet ports (VLAN / LAG).
Closes #304.
Acceptance tests pass:
TF_ACC=1 go test ./internal/provider/networking/network_ethernet_port_resource_test.go -v === RUN TestAccNetworkEthernetPortResource --- PASS: TestAccNetworkEthernetPortResource (16.33s) PASS ok command-line-arguments 16.338s
Example Terraform Configurations: