-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: Add SVM storage_limit
parameter
#328
base: integration/main
Are you sure you want to change the base?
[Enhancement]: Add SVM storage_limit
parameter
#328
Conversation
@acch before we can accept this we need you to follow this (https://github.com/NetApp/terraform-provider-netapp-ontap/blob/integration/main/CONTRIBUTING.md). I think the only steps missing right now is step 5. |
@carchi8py I had signed the NetApp CCLA on Oct 16... please let me know what's missing. |
@acch thank i have that now. Look like the email group we were using was not accepting External email so we didn't get a copy. We've fix that and have your CCLA. |
We have a major version 2.0 that in the final stages of our legal review. We will be adding this in to our 2.1 release which will be the release after that one. |
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
2fcb74a
to
b576f5f
Compare
@acch Happy Holidays, just a head up we will be reviewing this shorting. Sorry for the hold up we were waiting on Security to finish their review of 2.0 before releasing it and that ended up taking significantly longer than we had hope. Now that, that out of the way we are starting to merge thing in again. Right now I'm working on getting all the dependencies updated and then we'll start review these. Probably will have review the first week of Jan (or end of this week if I have time). |
Happy Holidays @carchi8py! Thanks for the update. Please let me know what I can do to help. Thanks much for all your efforts — enjoy a few days off! 🎄 |
Adds ability to configure
storage_limit
parameter of SVM.Closes #302.
Acceptance tests pass:
$ TF_ACC=1 go test ./internal/provider/svm/svm_resource_test.go -v === RUN TestAccSvmResource --- PASS: TestAccSvmResource (33.36s) PASS ok command-line-arguments 33.367s
Example Terraform Configuration: