Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add SVM storage_limit parameter #328

Open
wants to merge 6 commits into
base: integration/main
Choose a base branch
from

Conversation

acch
Copy link

@acch acch commented Oct 16, 2024

Adds ability to configure storage_limit parameter of SVM.

Closes #302.

Acceptance tests pass:

$ TF_ACC=1 go test ./internal/provider/svm/svm_resource_test.go -v
=== RUN   TestAccSvmResource
--- PASS: TestAccSvmResource (33.36s)
PASS
ok      command-line-arguments  33.367s

Example Terraform Configuration:

// sample SVM with storage_limit parameter
resource "netapp-ontap_svm" "example" {
  cx_profile_name = ...
  name            = ...
  ...
  storage_limit   = "4294967296"
}

@acch acch marked this pull request as ready for review October 16, 2024 12:31
@carchi8py carchi8py added the enhancement New feature or request label Oct 29, 2024
@carchi8py carchi8py added this to the 2.0 milestone Oct 29, 2024
@carchi8py
Copy link
Contributor

@acch before we can accept this we need you to follow this (https://github.com/NetApp/terraform-provider-netapp-ontap/blob/integration/main/CONTRIBUTING.md). I think the only steps missing right now is step 5.

@carchi8py carchi8py modified the milestones: 2.0, 2.1 Oct 29, 2024
@acch
Copy link
Author

acch commented Oct 30, 2024

@carchi8py I had signed the NetApp CCLA on Oct 16... please let me know what's missing.

@carchi8py
Copy link
Contributor

@acch thank i have that now. Look like the email group we were using was not accepting External email so we didn't get a copy. We've fix that and have your CCLA.

@carchi8py
Copy link
Contributor

We have a major version 2.0 that in the final stages of our legal review.

We will be adding this in to our 2.1 release which will be the release after that one.

@acch acch force-pushed the 302-svm-storage_limit-parameter branch from 2fcb74a to b576f5f Compare December 9, 2024 14:14
@carchi8py
Copy link
Contributor

@acch Happy Holidays, just a head up we will be reviewing this shorting. Sorry for the hold up we were waiting on Security to finish their review of 2.0 before releasing it and that ended up taking significantly longer than we had hope. Now that, that out of the way we are starting to merge thing in again. Right now I'm working on getting all the dependencies updated and then we'll start review these.

Probably will have review the first week of Jan (or end of this week if I have time).

@acch
Copy link
Author

acch commented Dec 22, 2024

Happy Holidays @carchi8py! Thanks for the update.
I'll be back in the office the first week of Jan., and will check if anything needs rebasing...

Please let me know what I can do to help.

Thanks much for all your efforts — enjoy a few days off! 🎄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 2.1
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add SVM storage_limit parameter
2 participants