Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update prometheus version v2.55.0 (#3223) #3226

Merged

Conversation

embusalacchi
Copy link
Contributor

No description provided.

@cgrinds
Copy link
Collaborator

cgrinds commented Oct 23, 2024

Thanks @embusalacchi. Version v2.55.0 of Prometheus passes our CI. Have you been running with this locally, and if so, any issues when upgrading from version 2.33.1?

@embusalacchi
Copy link
Contributor Author

Thanks @embusalacchi. Version v2.55.0 of Prometheus passes our CI. Have you been running with this locally, and if so, any issues when upgrading from version 2.33.1?

I have been running it in our production environment without any issues for the past 24 hours. If you want I can check back in after a week but so far so good. Is there something specific I can check for you? I would be glad to look into it more.

@cgrinds
Copy link
Collaborator

cgrinds commented Oct 23, 2024

We're still going through the cumulative change logs to better understand the scope of changes. There are several 😀.

In terms of things to check:

  • metrics are being scrapped
  • historical metrics are still available
  • dashboards that you use continue to work
  • ensure Prometheus log files are clean

I've also updated some of our internal systems and we'll check the above things on our end too.

Yes, plus report back with positive or negative impressions next week. Thanks!

@cgrinds
Copy link
Collaborator

cgrinds commented Oct 24, 2024

Upgrading Prometheus to v2.55.0 uncovered a minor bug in Harvest that is fixed in #3230 and future Prometheus warn|error log messages will be discovered in CI via #3232

@rahulguptajss
Copy link
Contributor

There is a documented issue here that still exists in version 2.55. Currently, Harvest does not utilize such queries.

@cgrinds
Copy link
Collaborator

cgrinds commented Nov 4, 2024

hi @embusalacchi any impressions on how version 2.55.0 of Prometheus has been running in your environment per #3226 (comment).

@embusalacchi
Copy link
Contributor Author

hi @embusalacchi any impressions on how version 2.55.0 of Prometheus has been running in your environment per #3226 (comment).

I haven't seen any issues in our environment. I haven't done a deep dive but our normal everyday usage hasn't seen anything different.

@cgrinds
Copy link
Collaborator

cgrinds commented Nov 4, 2024

Appreciate the feedback and PR

@cgrinds cgrinds merged commit ddb97c5 into NetApp:main Nov 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants