Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding Snapmirror Sources dashboard - 1 #3216

Merged
merged 12 commits into from
Nov 5, 2024
Merged

feat: Adding Snapmirror Sources dashboard - 1 #3216

merged 12 commits into from
Nov 5, 2024

Conversation

Hardikl
Copy link
Contributor

@Hardikl Hardikl commented Oct 21, 2024

image

@Hardikl
Copy link
Contributor Author

Hardikl commented Oct 21, 2024

SM
image

image

@rahulguptajss rahulguptajss marked this pull request as draft October 22, 2024 10:56
@rahulguptajss rahulguptajss linked an issue Oct 30, 2024 that may be closed by this pull request
@Hardikl Hardikl marked this pull request as ready for review October 30, 2024 14:55
Copy link
Contributor

@rahulguptajss rahulguptajss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description doesn't seem correct in some of other panels as well. Could you validate?

Also missing source path for below in .74.

image

Noticing below error in .74 for policy and lag detail table

Status: 422. Message: execution: found duplicate series for the match group {} on the right hand-side of the operation: [{name="snapmirror_labels", cluster="umeng-aff300-01-02", datacenter="nane", derived_relationship_type="mirror_vault", destination_location="xyz:harvest_ads_vol", destination_node="umeng-aff300-01", destination_volume="harvest_ads_vol", destination_vserver="xyz", group_type="vserver", healthy="true", instance="localhost:13002", job="prometheus", last_transfer_type="update", policy_type="mirror_vault", protectedBy="storage_vm", protectionSourceType="volume", relationship_status="idle", relationship_type="extended_data_protection", source_cluster="umeng-aff300-05-06", source_location="umeng-aff300-05-svm5:harvest_ads_vol", source_volume="harvest_ads_vol", source_vserver="umeng-aff300-05-svm5"}, {name="snapmirror_labels", cluster="umeng-aff300-01-02", datacenter="nane", derived_relationship_type="load_sharing", destination_location="umeng-aff300-01-02://astra_302/astra_302_m1", destination_volume="astra_302_m1", destination_vserver="astra_302", healthy="true", instance="localhost:13002", job="prometheus", local="true", relationship_status="idle", relationship_type="load_sharing", schedule="hourly", source_cluster="umeng-aff300-01-02", source_location="umeng-aff300-01-02://astra_302/astra_302_root", source_volume="astra_302_root", source_vserver="astra_302"}];many-to-many matching not allowed: matching labels must be unique on one side

grafana/dashboards/cmode/snapmirror.json Outdated Show resolved Hide resolved
grafana/dashboards/cmode/snapmirror.json Outdated Show resolved Hide resolved
@Hardikl
Copy link
Contributor Author

Hardikl commented Nov 4, 2024

Description doesn't seem correct in some of other panels as well. Could you validate?

Also missing source path for below in .74.

image Noticing below error in .74 for policy and lag detail table

Status: 422. Message: execution: found duplicate series for the match group {} on the right hand-side of the operation: [{name="snapmirror_labels", cluster="umeng-aff300-01-02", datacenter="nane", derived_relationship_type="mirror_vault", destination_location="xyz:harvest_ads_vol", destination_node="umeng-aff300-01", destination_volume="harvest_ads_vol", destination_vserver="xyz", group_type="vserver", healthy="true", instance="localhost:13002", job="prometheus", last_transfer_type="update", policy_type="mirror_vault", protectedBy="storage_vm", protectionSourceType="volume", relationship_status="idle", relationship_type="extended_data_protection", source_cluster="umeng-aff300-05-06", source_location="umeng-aff300-05-svm5:harvest_ads_vol", source_volume="harvest_ads_vol", source_vserver="umeng-aff300-05-svm5"}, {name="snapmirror_labels", cluster="umeng-aff300-01-02", datacenter="nane", derived_relationship_type="load_sharing", destination_location="umeng-aff300-01-02://astra_302/astra_302_m1", destination_volume="astra_302_m1", destination_vserver="astra_302", healthy="true", instance="localhost:13002", job="prometheus", local="true", relationship_status="idle", relationship_type="load_sharing", schedule="hourly", source_cluster="umeng-aff300-01-02", source_location="umeng-aff300-01-02://astra_302/astra_302_root", source_volume="astra_302_root", source_vserver="astra_302"}];many-to-many matching not allowed: matching labels must be unique on one side

All errors have been handled here, source_path need to be handled separately.

@cgrinds cgrinds merged commit 2ab127b into main Nov 5, 2024
8 checks passed
@cgrinds cgrinds deleted the hl_sm_source branch November 5, 2024 15:00
rahulguptajss added a commit that referenced this pull request Nov 6, 2024
* refactor: remove extra log

* feat: Adding Snapmirror Sources dashboard - 1 (#3216)

* feat: Adding Snapmirror Sources dashboard
---------

Co-authored-by: rahulguptajss <[email protected]>

---------

Co-authored-by: hardikl <[email protected]>
Co-authored-by: Hardikl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Snapmirror Source Dashboard
3 participants