refactor: simplify conf path management #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardikl
previously approved these changes
Aug 24, 2023
| // Path joins a set of path elems into a single path. | ||
| // The final path will be relative to the HARVEST_CONF environment variable | ||
| // or ./ when the environment variable is not set | ||
| func Path(elem ...string) string { |
There was a problem hiding this comment.
See if below makes sense. This will avoid HasSuffix check and provide a clean output path if elem has a relative path.
func Path(elem ...string) string {
home := os.Getenv("HARVEST_CONF")
if home == "" {
return filepath.Join(elem...)
}
allPaths := append([]string{home}, elem...)
return filepath.Join(allPaths...)
}
rahulguptajss
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.