fix: correct shelf metrics in 7mode #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hardikl
commented
Jul 31, 2023
Hardikl
commented
cgrinds
reviewed
Aug 2, 2023
Comment on lines
63
to
82
| my.shelfData = matrix.New(my.Parent+".Shelf", "shelf", "shelf") | ||
| my.shelfInstanceKeys = make([]string, 0) | ||
| my.shelfInstanceLabels = []shelfInstanceLabel{} | ||
| shelfExportOptions := node.NewS("export_options") | ||
| shelfInstanceKeys := shelfExportOptions.NewChildS("instance_keys", "") | ||
| shelfInstanceLabels := shelfExportOptions.NewChildS("instance_labels", "") | ||
|
|
||
| if counters := my.ParentParams.GetChildS("counters"); counters != nil { | ||
| if channelInfo := counters.GetChildS("shelf-environ-channel-info"); channelInfo != nil { | ||
| if shelfList := channelInfo.GetChildS("shelf-environ-shelf-list"); shelfList != nil { | ||
| if shelfInfo := shelfList.GetChildS("shelf-environ-shelf-info"); shelfInfo != nil { | ||
| my.parseShelfTemplate(shelfInfo, shelfInstanceKeys, shelfInstanceLabels, false, "") | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| shelfInstanceKeys.NewChildS("", "channel") | ||
| shelfInstanceKeys.NewChildS("", "shelf") | ||
| my.shelfData.SetExportOptions(shelfExportOptions) |
There was a problem hiding this comment.
Is it better to move all of this code in a seperate method? This may avoid lots of argument pass in parseShelfTemplate.
There was a problem hiding this comment.
moved couple of code line to other function. And reduce extra args, But we still need this parseTemplate as we do call it in recursion.
rahulguptajss
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.