feat: Harvest should fetch certificates via a script #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardikl
reviewed
Jul 28, 2023
Comment on lines
+321
to
+323
| o := &options.Options{} | ||
| options.SetPathsAndHostname(o) | ||
| pathPrefix = path.Join(o.HomePath, "cert/", o.Hostname) |
There was a problem hiding this comment.
these 3 lines could be outside this if block as it would be used by below if case also.
| } else { | ||
| username := pollerAuth.Username | ||
| password := pollerAuth.Password | ||
| client.username = username |
There was a problem hiding this comment.
we need to retain this line for username same as rest/client.go 89 line
rahulguptajss
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.