Skip to content

Commit

Permalink
fix: update keyperf collector static counter file path (#3241)
Browse files Browse the repository at this point in the history
* fix: update keyperf collector static counter file path

* feat: address review comments
  • Loading branch information
rahulguptajss authored Oct 30, 2024
1 parent 3059dca commit 8b62df9
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cmd/collectors/keyperf/keyperf.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ func (kp *KeyPerf) loadParamInt(name string, defaultValue int) int {
}

func (kp *KeyPerf) buildCounters() {
staticCounterDef, err := loadStaticCounterDefinitions(kp.Prop.Object, "cmd/collectors/keyperf/static_counter_definitions.yaml", kp.Logger)
staticCounterDef, err := loadStaticCounterDefinitions(kp.Prop.Object, "conf/keyperf/static_counter_definitions.yaml", kp.Logger)
if err != nil {
// It's acceptable to continue even if there are errors, as the remaining counters will still be processed.
// Any counters that require counter metadata will be skipped.
Expand Down
2 changes: 1 addition & 1 deletion cmd/tools/template/template_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ func visitTemplates(t *testing.T, eachTemplate func(path string, model Model), d
if ext != ".yaml" {
return nil
}
if strings.HasSuffix(path, "custom.yaml") || strings.HasSuffix(path, "default.yaml") {
if strings.HasSuffix(path, "custom.yaml") || strings.HasSuffix(path, "default.yaml") || strings.HasSuffix(path, "static_counter_definitions.yaml") {
return nil
}
model, err := ReadTemplate(path)
Expand Down

0 comments on commit 8b62df9

Please sign in to comment.