Merge remote-tracking branch 'origin/main' into hl_snapmirror_fix

.github/workflows/go.yml

@@ -1,7 +1,7 @@
 name: Build, Test, Lint License
 
 env:
-  GO_VERSION: "1.20.6"
+  GO_VERSION: "1.20.7"
 
 on:
   push:

.github/workflows/golangci-lint.yml

@@ -19,7 +19,7 @@ jobs:
     steps:
       - uses: actions/setup-go@v4
         with:
-          go-version: '1.20.6'
+          go-version: '1.20.7'
       - uses: actions/checkout@v3
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3

cmd/collectors/rest/plugins/volume/volume.go

@@ -11,17 +11,21 @@ import (
 	"github.com/netapp/harvest/v2/pkg/conf"
 	"github.com/netapp/harvest/v2/pkg/errs"
 	"github.com/netapp/harvest/v2/pkg/matrix"
+	"github.com/netapp/harvest/v2/pkg/tree/node"
 	"github.com/tidwall/gjson"
 	"strconv"
 	"strings"
 	"time"
 )
 
+const HoursInMonth = 24 * 30
+
 type Volume struct {
 	*plugin.AbstractPlugin
 	currentVal int
 	client     *rest.Client
 	aggrsMap   map[string]string // aggregate-uuid -> aggregate-name map
+	arw        *matrix.Matrix
 }
 
 func New(p *plugin.AbstractPlugin) plugin.Plugin {
@@ -55,6 +59,16 @@ func (my *Volume) Init() error {
 		return err
 	}
 
+	my.arw = matrix.New(my.Parent+".Volume", "volume_arw", "volume_arw")
+	exportOptions := node.NewS("export_options")
+	instanceKeys := exportOptions.NewChildS("instance_keys", "")
+	instanceKeys.NewChildS("", "ArwStatus")
+	my.arw.SetExportOptions(exportOptions)
+	_, err = my.arw.NewMetricFloat64("status", "status")
+	if err != nil {
+		my.Logger.Error().Stack().Err(err).Msg("add metric")
+		return err
+	}
 	return nil
 }
 
@@ -79,8 +93,11 @@ func (my *Volume) Run(dataMap map[string]*matrix.Matrix) ([]*matrix.Matrix, erro
 	// update volume instance labels
 	my.updateVolumeLabels(data)
 
+	// parse anti_ransomware_start_time, antiRansomwareState for all volumes and export at cluster level
+	my.handleARWProtection(data)
+
 	my.currentVal++
-	return nil, nil
+	return []*matrix.Matrix{my.arw}, nil
 }
 
 func (my *Volume) updateVolumeLabels(data *matrix.Matrix) {
@@ -96,6 +113,75 @@ func (my *Volume) updateVolumeLabels(data *matrix.Matrix) {
 	}
 }
 
+func (my *Volume) handleARWProtection(data *matrix.Matrix) {
+	var (
+		arwInstance       *matrix.Instance
+		arwStartTimeValue time.Time
+		err               error
+	)
+
+	// Purge and reset data
+	my.arw.PurgeInstances()
+	my.arw.Reset()
+
+	// Set all global labels
+	my.arw.SetGlobalLabels(data.GetGlobalLabels())
+	arwStatusValue := "Active Mode"
+	// Case where cluster don't have any volumes, arwStatus show as 'Not Monitoring'
+	if len(data.GetInstances()) == 0 {
+		arwStatusValue = "Not Monitoring"
+	}
+
+	// This is how cluster level arwStatusValue has been calculated based on each volume
+	// If any one volume arwStatus is disabled --> "Not Monitoring"
+	// If any one volume has been completed learning mode --> "Switch to Active Mode"
+	// If all volumes are in learning mode --> "Learning Mode"
+	// Else indicates arwStatus for all volumes are enabled --> "Active Mode"
+	for _, volume := range data.GetInstances() {
+		if arwState := volume.GetLabel("antiRansomwareState"); arwState == "" {
+			// Case where REST call don't return `antiRansomwareState` field, arwStatus show as 'Not Monitoring'
+			arwStatusValue = "Not Monitoring"
+			break
+		} else {
+			if arwState == "disabled" {
+				arwStatusValue = "Not Monitoring"
+				break
+			} else if arwState == "dry_run" || arwState == "enable_paused" {
+				arwStartTime := volume.GetLabel("anti_ransomware_start_time")
+				if arwStartTime == "" || arwStatusValue == "Switch to Active Mode" {
+					continue
+				}
+				// If ARW startTime is more than 30 days old, which indicates that learning mode has been finished.
+				if arwStartTimeValue, err = time.Parse(time.RFC3339, arwStartTime); err != nil {
+					my.Logger.Error().Err(err).Msg("Failed to parse arw start time")
+					arwStartTimeValue = time.Now()
+				}
+				if time.Since(arwStartTimeValue).Hours() > HoursInMonth {
+					arwStatusValue = "Switch to Active Mode"
+				} else {
+					arwStatusValue = "Learning Mode"
+				}
+			}
+		}
+	}
+
+	arwInstanceKey := data.GetGlobalLabels().Get("cluster") + data.GetGlobalLabels().Get("datacenter")
+	if arwInstance, err = my.arw.NewInstance(arwInstanceKey); err != nil {
+		my.Logger.Error().Err(err).Str("arwInstanceKey", arwInstanceKey).Msg("Failed to create arw instance")
+		return
+	}
+
+	arwInstance.SetLabel("ArwStatus", arwStatusValue)
+	m := my.arw.GetMetric("status")
+	// populate numeric data
+	value := 1.0
+	if err = m.SetValueFloat64(arwInstance, value); err != nil {
+		my.Logger.Error().Stack().Err(err).Float64("value", value).Msg("Failed to parse value")
+	} else {
+		my.Logger.Debug().Float64("value", value).Msg("added value")
+	}
+}
+
 func (my *Volume) getEncryptedDisks() ([]gjson.Result, error) {
 	var (
 		result []gjson.Result

conf/rest/9.12.0/ems_destination.yaml

@@ -0,0 +1,25 @@
+
+name:             EmsDestination
+query:            api/support/ems/destinations
+object:           ems_destination
+
+counters:
+  - ^^destination      => destination
+  - ^^name             => name
+  - ^^type             => type
+  - ^certificate.ca    => certificate
+  - ^filter            => filter
+  - ^syslog            => syslog
+  - ^system_defined    => system_defined
+  - filter:
+    - system_defined=false
+
+export_options:
+  instance_keys:
+    - destination
+    - name
+    - type
+  instance_labels:
+    - certificate
+    - filter
+    - syslog

conf/rest/9.12.0/support_auto_update.yaml

@@ -0,0 +1,13 @@
+
+name:             SupportAutoUpdate
+query:            api/support/auto-update
+object:           support_auto_update
+
+counters:
+  - ^enabled          => auto_update_enabled
+
+export_options:
+  instance_keys:
+    - auto_update_enabled
+  instance_labels:
+    - auto_update_enabled

conf/rest/9.12.0/volume.yaml

@@ -9,11 +9,13 @@ counters:
   - ^^svm.name                                    => svm
   - ^aggregates.#.name                            => aggr
   - ^aggregates.#.uuid                            => aggrUuid        # handled in plugin for flexgroup
+  - ^anti_ransomware.dry_run_start_time           => anti_ransomware_start_time
   - ^anti_ransomware.state                        => antiRansomwareState
   - ^encryption.enabled                           => isEncrypted
   - ^is_svm_root                                  => svm_root
   - ^snaplock.type                                => snaplock_type
   - ^snapshot_policy.name                         => snapshot_policy
+  - ^space.snapshot.autodelete.enabled            => snapshot_autodelete
   - ^state                                        => state
   - ^style                                        => style
   - ^type                                         => type
@@ -43,6 +45,7 @@ counters:
   - space.snapshot.used                           => snapshots_size_used
   - space.used                                    => size_used
   - hidden_fields:
+      - anti_ransomware.dry_run_start_time
       - anti_ransomware.state
       - autosize
       - encryption.enabled
@@ -137,6 +140,7 @@ export_options:
     - is_sis_volume
     - root_volume
     - snaplock_type
+    - snapshot_autodelete
     - snapshot_policy
     - state
     - svm_root

conf/rest/default.yaml

@@ -13,6 +13,7 @@ objects:
   CloudTarget:                 cloud_target.yaml
   ClusterPeer:                 clusterpeer.yaml
   Disk:                        disk.yaml
+  EmsDestination:              ems_destination.yaml
 #  ExportRule:                  exports.yaml
   LIF:                         lif.yaml
   Health:                      health.yaml
@@ -42,6 +43,7 @@ objects:
   Status:                      status.yaml
   Subsystem:                   subsystem.yaml
   Support:                     support.yaml
+  SupportAutoUpdate:           support_auto_update.yaml
   SVM:                         svm.yaml
   Volume:                      volume.yaml
   VolumeAnalytics:             volume_analytics.yaml

conf/zapi/cdot/9.8.0/ems_destination.yaml

@@ -0,0 +1,27 @@
+name:       EmsDestination
+query:      ems-event-notification-destination-get-iter
+object:     ems_destination
+
+counters:
+  event-notification-destination-info:
+    - ^^certificate-authority   => certificate
+    - ^^name                    => name
+    - ^^type                    => type
+    - destination:
+        - ^^string              => destination
+
+collect_only_labels: true
+
+plugins:
+  - LabelAgent:
+      exclude_equals:
+        - destination ``
+
+export_options:
+  instance_keys:
+    - destination
+    - name
+    - type
+  instance_labels:
+    - certificate
+

conf/zapi/cdot/9.8.0/volume.yaml

@@ -37,6 +37,8 @@ counters:
         - ^auto-snapshots-enabled               => auto_snapshots_enabled
         - ^snapshot-policy
         - snapshot-count
+    - volume-snapshot-autodelete-attributes:
+        - ^is-autodelete-enabled                => snapshot_autodelete
     - volume-space-attributes:
         - expected-available
         - filesystem-size                       => filesystem_size
@@ -117,6 +119,7 @@ export_options:
     - is_sis_volume
     - node_root
     - root_volume
+    - snapshot_autodelete
     - snapshot_policy
     - state
     - svm_root

conf/zapi/default.yaml

@@ -11,6 +11,7 @@ objects:
   CIFSSession:                 cifs_session.yaml
   ClusterPeer:                 clusterpeer.yaml
   Disk:                        disk.yaml
+  EmsDestination:              ems_destination.yaml
   LIF:                         lif.yaml
   Lun:                         lun.yaml
 #  NetPort:                     netPort.yaml