Shamir Secret Sharing #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sword-Smith
reviewed
Jan 28, 2025
Sword-Smith
reviewed
Jan 28, 2025
src/models/state/wallet/mod.rs
Outdated
| @@ -49,14 +53,153 @@ pub const WALLET_DB_NAME: &str = "wallet"; | |||
| pub const WALLET_OUTPUT_COUNT_DB_NAME: &str = "wallout_output_count_db"; | |||
|
|
|||
| #[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Eq)] | |||
| struct SecretKeyMaterial(XFieldElement); | |||
| pub struct SecretKeyMaterial(XFieldElement); | |||
There was a problem hiding this comment.
Can we use pub(crate) here for SecretKeyMaterial and all its new associated functions?
There was a problem hiding this comment.
The problem is that they are being used from within neptune-cli.rs, which lives in its own crate and therefore does not have access to structs and functions marked pub(crate).
Sword-Smith
requested changes
Jan 28, 2025
Sword-Smith
approved these changes
Jan 29, 2025
Add support for splitting secret key material into n shares such that: - combining *any* t < n of them is enough to reproduce the original secret; and - combining *fewer* than t yields no information about the original secret. Addresses #325.
Add two CLI commands: - `shamir-share t n`: Split the wallet secret into n shares such that any t of them can reproduce the original secret with ... - `shamir-recombine t`: Combine t Shamir secret shares to reconstruct a wallet secret. Closes #325.
Specifically, add chapter "User Guides" and page "installation". The latter duplicates instructions from the README.md.
Use `println!` instead of `bail!` to inform user of absent wallet file. The wallet file being absent does not indicate a programmer or even user error. The stack trace here is of no use to anyone.
Also: enable LaTeX.
Co-authored-by: Thorkil Schmidiger <[email protected]>
Co-authored-by: Thorkil Schmidiger <[email protected]>
aszepieniec
force-pushed
the
asz/shamir
branch
from
440e29a to
db391f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is rather uncontroversial but it can't hurt to offer the opportunity for review.